Apply role based search filters in existing endpoints #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check authorization in DataAutoCompleteController
…er in public methods
chenejac
previously approved these changes
Mar 12, 2024
There was a problem hiding this comment.
@litvinovg thanks for this PR.
I have posted a couple of comments in the case you have any idea how to additionally improve efficiency of the implementation. Basically, it is about invoking current roles multiple time in some cases. It is the most important that permission set is loaded just one (and it is the case at the moment), therefore I am approving this PR.
...in/java/edu/cornell/mannlib/vitro/webapp/controller/freemarker/IndividualListController.java
Show resolved
Hide resolved
...in/java/edu/cornell/mannlib/vitro/webapp/controller/freemarker/IndividualListController.java
Show resolved
Hide resolved
...src/main/java/edu/cornell/mannlib/vitro/webapp/search/controller/AutocompleteController.java
Show resolved
Hide resolved
litvinovg
force-pushed
the
search_endpoints_hide_data
branch
from
3cb3103
to
eb8cac5
Compare
chenejac
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
A follow-up PR for recently merged PR-433 and PR-434
to apply role based search filters in existing endpoints.
What's new?
Applied search filters in IndividualListController, AutocompleteController
Fixed unsafe DataAutoCompleteController, perform authorization checks for each returned result.
Refactored SearchFiltering methods to remove dependency on not needed VitroRequest parameter
Applied search filters to DefaultObjectPropertyFormGeneratory
Removed unused import in DefaultObjectPropertyFormGenerator
How should this be tested?
A description of what steps someone could take to:
Interested parties
@VIVO-project/vivo-committers