pro plan options #555
Merged
pro plan options #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t the posible client. Pending changes marked as a comment with "TODO"
elboletaire
requested changes
Feb 21, 2024
jpaulet
approved these changes
Feb 23, 2024
elboletaire
requested changes
Feb 28, 2024
There was a problem hiding this comment.
A part from the code changes in the review, there are some other visual things that should be addressed:
These should not be overlapping with the census manager.
Probably related to the wrong features initialization, disabling features does not seem to be working:
This is the rendered component after setting FEATURES='{"voting":["single"]}'
|
🚀 Deployed on https://660c2bbea113be42320d6bbf--onvote-stg.netlify.app |
elboletaire
requested changes
Mar 26, 2024
.env.example
Outdated
| @@ -1,2 +1,2 @@ | |||
| VOCDONI_ENVIRONMENT=prod | |||
| FEATURES='{"faucet":true,"vote":{"anonymous":true,"overwrite":true,"secret":true},"login":["web3","web2"],"census":["spreadsheet","token","web3"],"languages":["en","es","ca"]}' | |||
| FEATURES='{"faucet":true,"vote":{"anonymous":true,"overwrite":true,"secret":true,"customization":true},"types":{"single":true,"multi":true,"approval":true,"participatory":true,"borda":true},"login":["web3","web2"],"census":["spreadsheet","token","web3"],"unimplemented_census":["phone","email","crm","database","digital_certificate"],"languages":["en","es","ca"]}' | |||
There was a problem hiding this comment.
This example does not match with the actual implementation.
There was a problem hiding this comment.
@gerouvi I still miss the unimplemented_voting_types and voting_types in that FEATURES env 🤔
elboletaire
reviewed
Apr 2, 2024
elboletaire
approved these changes
Apr 2, 2024
This was referenced Apr 2, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the options of the Pro Plan with the modal to send an email requiring them or scheduling an appointment