Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor onvote landing #607

Merged
merged 13 commits into from Apr 2, 2024
Merged

Refactor onvote landing #607

merged 13 commits into from Apr 2, 2024

Conversation

selankon
Copy link
Contributor

Fixes #592

Copy link

github-actions bot commented Mar 20, 2024

Copy link

github-actions bot commented Mar 20, 2024

@github-actions github-actions bot temporarily deployed to pull request March 20, 2024 08:15 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 20, 2024 08:15 Inactive
Copy link

github-actions bot commented Mar 20, 2024

@github-actions github-actions bot temporarily deployed to pull request March 20, 2024 08:15 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 20, 2024 08:20 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 20, 2024 08:20 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 20, 2024 08:20 Inactive
@selankon selankon marked this pull request as ready for review March 20, 2024 08:32
@github-actions github-actions bot temporarily deployed to pull request March 20, 2024 08:33 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 20, 2024 08:33 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 20, 2024 08:33 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 20, 2024 08:49 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 20, 2024 08:49 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 20, 2024 08:49 Inactive
@elboletaire
Copy link
Member

These links don't work
imatge

Also, I'm not really sure about the translation change you told me the other day... I don't see those modules being used in vocdoni app (?)

@selankon
Copy link
Contributor Author

These links don't work imatge

Also, I'm not really sure about the translation change you told me the other day... I don't see those modules being used in vocdoni app (?)

Fixed on 07ebb63

@github-actions github-actions bot temporarily deployed to pull request March 22, 2024 10:46 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 22, 2024 10:46 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 22, 2024 10:47 Inactive
@elboletaire elboletaire self-assigned this Mar 22, 2024
@elboletaire
Copy link
Member

Assigned to myself since I'd like to take a look to the translation issue we're having losing translations for themes different than the default one.

@selankon selankon requested a review from jpaulet March 27, 2024 11:15
@jpaulet
Copy link
Member

jpaulet commented Mar 29, 2024

After reviewing it, I changed a bit the look & feel to unify with the rest of the page:

image

  • Changed the links text
  • Change the title to the "pixeloid" font family
  • Changed some text
  • Solve the "&" to "&".
  • Change the font-wight of the links to 600;
  • Remove the background-color and shadow of the cards
  • Add more vertical space (top bottom)
  • Add the "Our Web3 governance solutions" title
  • Add margin-bottom after the "Onvote", "Farcaster".. titles & the description
  • Add bold to the descriptions

Copy link
Member

@jpaulet jpaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review the changes commented in the previous comment

@selankon selankon requested a review from jpaulet April 2, 2024 08:55
Copy link
Member

@elboletaire elboletaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please either rebase or merge develop into this to fix the merge conflicts.

@github-actions github-actions bot temporarily deployed to pull request April 2, 2024 11:06 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 2, 2024 11:06 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 2, 2024 11:06 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 2, 2024 12:19 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 2, 2024 12:19 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 2, 2024 12:19 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 2, 2024 14:31 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 2, 2024 14:31 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 2, 2024 14:33 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 2, 2024 14:33 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 2, 2024 14:33 Inactive
@elboletaire elboletaire merged commit 4797d55 into develop Apr 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Onvote landing
3 participants