Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use dependency injection for extra pluginmanager #1818

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

piffio
Copy link
Contributor

@piffio piffio commented Oct 19, 2019

This PR is still WIP, do not merge yet

Make the stardard plugin manager myvolumio agnostic, by using dependency
injection to pass in the right "extra pluginmanager" when it
instanciated.
This will allow for passing alternative pluginmanagers for specific OEMs
as well as making the code more testable, which will become useful in
the future.

Make the stardard plugin manager myvolumio agnostic, by using dependency
injection to pass in the right "extra pluginmanager" when it
instanciated.
This will allow for passing alternative pluginmanagers for specific OEMs
as well as making the code more testable, which will become useful in
the future.
@volumio
Copy link
Owner

volumio commented Feb 21, 2020

@piffio is it still relevant? can you check against regression before merging?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants