Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download stable version of composer as opposed to snapshot #576

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

plexium
Copy link

@plexium plexium commented May 12, 2020

Pull Request (PR) description

Download stable version of composer as opposed to snapshot

This Pull Request (PR) fixes the following issues

Fixes #575

@dhoppe dhoppe requested a review from bastelfreak May 18, 2020 07:42
@bastelfreak
Copy link
Member

Is this a backwards incompatible change? The fold url is still valid, just a different composer version?

@bastelfreak bastelfreak added the needs-feedback Further information is requested label May 18, 2020
@dhoppe
Copy link
Member

dhoppe commented May 18, 2020

Is this a backwards incompatible change? The fold url is still valid, just a different composer version?

In my opinion this looks more like a bug fix:

By default the installer and composer self-update will download stable versions only. If you would like to help test pre-release versions you can use the --preview flag on either installer or self-update. For snapshot builds which are done from the latest Composer commit, you can use the --snapshot flag.

@plexium
Copy link
Author

plexium commented May 22, 2020

Is this a backwards incompatible change? The fold url is still valid, just a different composer version?

Correct, it's still a valid url. I noticed this being a problem when provisioning a new node, the composer version that would install was a dev version, and caused a bunch of composer installs downstream in my manifests to fail. I would have to manually do a composer selfupdate after provisioning to get the stable version.

Since is saw the update branch defaults to the 'stable', so should the initial install.

I don't think it's a backwards incompatible change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-feedback Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snapshot composer is installed instead of stable composer
3 participants