Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Zabbix 6.4 to CI matrix #936

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Zabbix 6.4 to CI matrix #936

wants to merge 1 commit into from

Conversation

bastelfreak
Copy link
Member

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@bastelfreak bastelfreak added the enhancement New feature or request label Mar 17, 2024
@bastelfreak bastelfreak self-assigned this Mar 17, 2024
kenyon
kenyon reviewed Mar 17, 2024
View reviewed changes
Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add 6.4 here too I guess:

puppet-zabbix/spec/support/acceptance/supported_versions.rb

Line 4 in 68b391e

supported_versions = %w[5.0 6.0]

@Valantin
Copy link
Member

Are you sure you want to add 6.4?
It's eol is june

I think is better to test only LTS because non LTS support is 6 mounth or next LTS release

Valantin
Valantin requested changes Mar 18, 2024
View reviewed changes
Copy link
Member

@Valantin Valantin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

puppet-zabbix/spec/support/acceptance/supported_versions.rb

Line 4 in 81b96f3

supported_versions = %w[5.0 6.0]

and probably

puppet-zabbix/.sync.yml

Line 16 in 81b96f3

beaker_facter: 'zabbix_version:Zabbix:5.0,6.0'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenyon kenyon kenyon left review comments

@Valantin Valantin Valantin requested changes

Assignees

@bastelfreak bastelfreak

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bastelfreak @Valantin @kenyon