Elasticsearch 7 driver #440
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peterpp any chance you could make this PR against https://github.com/adminerevo/adminerevo so it could become a part of a regular release? (Thank you! :-) |
|
Yes, I noticed activity around adminerevo and I'm happy that somebody is willing to do at least basic maintenance. I am quite busy right now, but I will prepare it. |
Signed-off-by: Roy-Orbison <Roy-Orbison@users.noreply.github.com> (cherry picked from commit 2717333)
(cherry picked from commit fad4ce7)
(cherry picked from commit 496ab9a)
(cherry picked from commit 6024d73)
(cherry picked from commit 33fcfbc)
(cherry picked from commit 7338ead)
and fix a media query. Signed-off-by: Lucas Sandery <lucas-sandery@users.noreply.github.com> (cherry picked from commit 4b0b011)
- Allow only scheme, host and port in the server field. - Use proper default host and port in Elasticsearch and ClickHouse driver.
In Elasticsearch, only indexed fields are searchable.
In Elasticsearch, text fields are not sortable.
peterpp
force-pushed
the
elastic7
branch
8 times, most recently
from
2e15434
to
515708c
Compare
- Allow to choose "must", "should", "must_not" condition. - Add system "_id" column to the field list. So it can be used in search condition.
- Allow to search only in fields with index.
Mapping types are still supported in version 6, but only one mapping type can be created. In version 7, mapping types are deprecated and there is only one system '_doc' mapping type. See: https://www.elastic.co/guide/en/elasticsearch/reference/6.0/removal-of-types.html
- Removed empty body from requests.
peterpp
force-pushed
the
elastic7
branch
5 times, most recently
from
285c6b8
to
04ecf52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Elasticsearch 7, mapping types are deprecated and there is only one system '_doc' mapping type. It does not make sense to display it anymore. So the whole presentation of Elastic indices in Adminer can be much improved. Indices can be treated as SQL tables instead of databases.
As long as this new approach is completelly different, it would by complicated to handle it by conditions in the current Elastic driver. And I honestly don't want to bother with it. So I created a brand new driver
elastic7as a plugin and use it happily.Note that this branch is rebased onto
field-priviliges(#422) which is required for this driver to work corretly.