Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icon): support for .code-snippet and .code-workspace extensions #3229

Merged
merged 7 commits into from Apr 23, 2023

Conversation

remcohaszing
Copy link
Contributor

@remcohaszing remcohaszing commented Feb 6, 2023

Use the VSCode icon for code-snippets and .code-workspace files.

Changes proposed:

  • Add

@remcohaszing
Copy link
Contributor Author

I don’t understand the failing test.

  1) Specifications of supported extensions: tests
       ensures that
         each supported
           extension
             does NOT have
               same declaration with different 'extensions':
     AssertionError: expected [ Array(1) ] to be empty
      at /home/remco/Projects/vscode-icons/out/test/iconsManifest/specsExtensions.test.js:2:5377
      at Array.forEach (<anonymous>)
      at Context.<anonymous> (out/test/iconsManifest/specsExtensions.test.js:2:5042)
      at process.processImmediate (node:internal/timers:475:21)

If I add the extension to the entries that already exist, the icon isn’t applied.

@voidei
Copy link
Contributor

voidei commented Feb 17, 2023

@remcohaszing I think I fixed it? I have no idea why exactly what I did works, but I changed it from

    {
      icon: 'vscode',
      extensions: ['code-workspace'],
      format: FileFormat.svg,
    },

to

    {
      icon: 'vscode',
      extensions: ['code-workspace', 'code-snippets'],
      filenamesGlob: [],
      extensionsGlob: [],
      filename: false,
      format: FileFormat.svg,
    },

Tried it with only code-workspace in there, only code-snippets, and of course both - test runs without issues on my end. As I said I have no clue why that works, but if it works then it works 🤷

@remcohaszing remcohaszing changed the title feat(icon): support for .code-workspace extension feat(icon): support for .code-snippet and .code-workspace extensions Feb 17, 2023
@remcohaszing
Copy link
Contributor Author

That works! Thanks!

@robertohuertasm robertohuertasm added this to the Backlog milestone Apr 10, 2023
@robertohuertasm robertohuertasm merged commit 74220b6 into vscode-icons:master Apr 23, 2023
13 checks passed
@remcohaszing remcohaszing deleted the code-workspace branch April 23, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants