-
-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(icon): support for .code-snippet and .code-workspace extensions #3229
feat(icon): support for .code-snippet and .code-workspace extensions #3229
Conversation
f9dfcac
to
c96192e
Compare
I don’t understand the failing test.
If I add the extension to the entries that already exist, the icon isn’t applied. |
@remcohaszing I think I fixed it? I have no idea why exactly what I did works, but I changed it from {
icon: 'vscode',
extensions: ['code-workspace'],
format: FileFormat.svg,
}, to {
icon: 'vscode',
extensions: ['code-workspace', 'code-snippets'],
filenamesGlob: [],
extensionsGlob: [],
filename: false,
format: FileFormat.svg,
}, Tried it with only |
That works! Thanks! |
Use the VSCode icon for
code-snippets
and.code-workspace
files.Changes proposed: