Infrastructure: add Ava ESLint plug-in with recommended rules (pull #…

…1566)

* add ava ESLint plug-in
* fix: Ava ESLint recommended cleanups
   * No strict declaration in Ava module files
   * Ignore the "index" test file as it isn't directly called
   * Fix async/await functions
   * `after.always` hook must come before `beforeEach`

package.json

@@ -35,6 +35,7 @@
     "cspell": "^4.1.2",
     "eslint": "^7.11.0",
     "eslint-config-prettier": "^6.12.0",
+    "eslint-plugin-ava": "^11.0.0",
     "eslint-plugin-prettier": "^3.1.4",
     "geckodriver": "^1.20.0",
     "glob": "^7.1.6",

test/.eslintrc.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../.eslintrc.json",
+  "extends": ["../.eslintrc.json", "plugin:ava/recommended"],
   "parserOptions": {
     "ecmaVersion": 8
   }

test/index.js

@@ -1,4 +1,4 @@
-'use strict';
+/* eslint-disable ava/no-ignored-test-files */
 
 const path = require('path');
 const test = require('ava');
@@ -29,18 +29,22 @@ if (!coverageReportRun) {
     await session;
   });
 
+  test.after.always(async () => {
+    if (session) {
+      await session.close();
+    }
+
+    if (geckodriver) {
+      await geckodriver.stop();
+    }
+  });
+
   test.beforeEach((t) => {
     t.context.session = session;
     t.context.waitTime = testWaitTime;
     t.context.queryElement = queryElement;
     t.context.queryElements = queryElements;
   });
-
-  test.after.always(() => {
-    return Promise.resolve(session && session.close()).then(
-      () => geckodriver && geckodriver.stop()
-    );
-  });
 }
 
 /**
@@ -75,7 +79,7 @@ const _ariaTest = (desc, page, testId, body, failing) => {
   const testName = page + ' ' + selector + ': ' + desc;
 
   if (coverageReportRun) {
-    test(testName, async function (t) {
+    test(testName, function (t) {
       t.fail('All tests expect to fail. Running in coverage mode.');
     });
     return;

test/tests/accordion_accordion.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By, Key } = require('selenium-webdriver');
 const assertAriaControls = require('../util/assertAriaControls');

test/tests/alert_alert.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By } = require('selenium-webdriver');
 

test/tests/breadcrumb_index.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By } = require('selenium-webdriver');
 const assertAriaLabelExists = require('../util/assertAriaLabelExists');

test/tests/button_button.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By, Key } = require('selenium-webdriver');
 

test/tests/carousel_carousel-1-prev-next.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By, Key } = require('selenium-webdriver');
 const assertAttributeValues = require('../util/assertAttributeValues');

test/tests/carousel_carousel-2-tablist.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By, Key } = require('selenium-webdriver');
 const assertAttributeValues = require('../util/assertAttributeValues');

test/tests/checkbox_checkbox-1.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By, Key } = require('selenium-webdriver');
 const assertAttributeValues = require('../util/assertAttributeValues');

test/tests/checkbox_checkbox-2.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By, Key } = require('selenium-webdriver');
 const assertAttributeValues = require('../util/assertAttributeValues');

test/tests/combobox_autocomplete-both.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By, Key } = require('selenium-webdriver');
 const assertAttributeValues = require('../util/assertAttributeValues');

test/tests/combobox_autocomplete-list.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By, Key } = require('selenium-webdriver');
 const assertAttributeValues = require('../util/assertAttributeValues');

test/tests/combobox_autocomplete-none.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By, Key } = require('selenium-webdriver');
 const assertAttributeValues = require('../util/assertAttributeValues');

test/tests/combobox_datepicker.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By, Key } = require('selenium-webdriver');
 const assertAttributeValues = require('../util/assertAttributeValues');

test/tests/combobox_grid-combo.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By, Key } = require('selenium-webdriver');
 const assertAriaLabelledby = require('../util/assertAriaLabelledby');

test/tests/combobox_select-only.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By, Key } = require('selenium-webdriver');
 const assertAttributeValues = require('../util/assertAttributeValues');

test/tests/dialog-modal_datepicker.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By, Key } = require('selenium-webdriver');
 const assertAttributeValues = require('../util/assertAttributeValues');

test/tests/dialog-modal_dialog.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By, Key } = require('selenium-webdriver');
 const assertAttributeValues = require('../util/assertAttributeValues');

test/tests/disclosure_faq.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By, Key } = require('selenium-webdriver');
 const assertAriaControls = require('../util/assertAriaControls');

test/tests/disclosure_img-long-description.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By, Key } = require('selenium-webdriver');
 const assertAriaControls = require('../util/assertAriaControls');

test/tests/disclosure_navigation.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By, Key } = require('selenium-webdriver');
 const assertAriaControls = require('../util/assertAriaControls');

test/tests/feed_feed.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By, Key } = require('selenium-webdriver');
 

test/tests/grid_LayoutGrids.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By, Key } = require('selenium-webdriver');
 

test/tests/grid_dataGrids.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By, Key } = require('selenium-webdriver');
 const assertAriaLabelledby = require('../util/assertAriaLabelledby');

test/tests/link_link.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By, Key } = require('selenium-webdriver');
 const assertAriaLabelExists = require('../util/assertAriaLabelExists');

test/tests/listbox_collapsible.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By, Key } = require('selenium-webdriver');
 const assertAttributeValues = require('../util/assertAttributeValues');

test/tests/listbox_grouped.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By, Key } = require('selenium-webdriver');
 const assertAttributeValues = require('../util/assertAttributeValues');

test/tests/listbox_rearrangeable.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By, Key } = require('selenium-webdriver');
 const assertAttributeValues = require('../util/assertAttributeValues');

test/tests/listbox_scrollable.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By, Key } = require('selenium-webdriver');
 const assertAttributeValues = require('../util/assertAttributeValues');

test/tests/menu-button_actions-active-descendant.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By, Key } = require('selenium-webdriver');
 const assertAttributeValues = require('../util/assertAttributeValues');

test/tests/menu-button_actions.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By, Key } = require('selenium-webdriver');
 const assertAttributeValues = require('../util/assertAttributeValues');

test/tests/menu-button_links.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By, Key } = require('selenium-webdriver');
 const assertAttributeValues = require('../util/assertAttributeValues');

test/tests/menubar_menubar-editor.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By, Key } = require('selenium-webdriver');
 const assertAttributeValues = require('../util/assertAttributeValues');

test/tests/menubar_menubar-navigation.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By, Key } = require('selenium-webdriver');
 const assertAttributeValues = require('../util/assertAttributeValues');

test/tests/meter_meter.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By } = require('selenium-webdriver');
 const assertAriaLabelledby = require('../util/assertAriaLabelledby');

test/tests/radio_radio-activedescendant.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By, Key } = require('selenium-webdriver');
 const assertAttributeValues = require('../util/assertAttributeValues');

test/tests/radio_radio.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { By, Key } = require('selenium-webdriver');
 const assertAttributeValues = require('../util/assertAttributeValues');

test/tests/slider_multithumb.js

@@ -1,5 +1,3 @@
-'use strict';
-
 const { ariaTest } = require('..');
 const { Key } = require('selenium-webdriver');
 const assertAttributeValues = require('../util/assertAttributeValues');