Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression Tests: Enable disclosure_navigation.js test to scroll to element #2997

Merged
merged 1 commit into from May 5, 2024

Conversation

howard-e
Copy link
Contributor

@howard-e howard-e commented Apr 25, 2024

Fixes #2996.

Update ../tests/disclosure_navigation.js test > "aria-current" attribute on links to scroll to link before click event.


WAI Preview Link (Last built on Thu, 25 Apr 2024 19:28:54 GMT).

@howard-e howard-e added the regression-testing Related to AVA regression tests of example pages or AVA framework implementation within repo label Apr 25, 2024
@howard-e howard-e changed the title Address disclosure_navigation.js test being unable to scroll to element. Fix disclosure_navigation.js test being unable to scroll to element. Apr 25, 2024
@howard-e howard-e changed the title Fix disclosure_navigation.js test being unable to scroll to element. Fix disclosure_navigation.js test being unable to scroll to element Apr 25, 2024
@mcking65 mcking65 changed the title Fix disclosure_navigation.js test being unable to scroll to element Regression Tests: Enable disclosure_navigation.js test to scroll to element Apr 29, 2024
@mcking65 mcking65 requested a review from alflennik April 29, 2024 15:06
@mcking65 mcking65 merged commit 2a4ee4b into main May 5, 2024
17 checks passed
@mcking65 mcking65 deleted the bocoup/fix-issue-2996 branch May 5, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-testing Related to AVA regression tests of example pages or AVA framework implementation within repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing disclosure_navigation.js test
3 participants