Update F91 to remove unrelated techniques #3821
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #3788 removes f46, g115 and g63 as they aren't directly related to not marking up table headers correctly. The issue said all but H43 should be removed, but H51 demonstrates how to build a table with correctly marked up headers, so i see no reason why this shouldn't still be linked. As it stands, support for the headers attribute is rather lack luster - so pointing to a generic use of setting up a table with correct usage of the th element is worth not removing.
|
@detlevhfischer could you clarify what you are trying to communicate with your list of links? are you saying there should be more links, that these links are still in the doc, that these links (pages) link to this particular technique? |
|
@scottaohara I didn't intend to communicate anything specific - I just find it easier to assess a PR when there are links to the Techniques (or other resources) discussed, and wanted to provide that comfort to others surveying the change. I also often put in a link to a githack-rendered version of the results of a PR because I find it much easier to read than going through the source code. |
bruce-usab
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3788
removes f46, g115 and g63 as they aren't directly related to not marking up table headers correctly.
The issue said all but H43 should be removed, but H51 demonstrates how to build a table with correctly marked up headers, so i see no reason why this shouldn't still be linked. As it stands, support for the headers attribute is rather lack luster - so pointing to a generic use of setting up a table with correct usage of the th element is worth not removing.