Edits for PR614 for review #639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did a heavier edit on my PR using input in the survey. I'll revisit each of your changes and see if it is now covered. |
|
@mbgower I had other edits that were in a branch that for some reason didn't wind up in my pull request to your branch. I'll sort those out. In general, I'm still concerned that your edits still treat "close proximity" as a normative concept and I don't think that we can do that. Some of my missing edits help make this more clear. I'm perfectly fine with suggesting that as a best practice, but since the definition of close proximity is subjective we can't use it to define the bounds of the SC. |
|
No longer needed as #614 was updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.