adds removeNode #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add return type to range for strict mode
|
Thanks a lot! Let me take a look at the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
removeNode(which was in doc but not implemented). This allows the replacement of a node with particular data, given a tree with duplicates.It uses the first remove strategy in the wikipedia article, as splay() only works up to key equality.
It also uses removeNode() to implement remove(): arguably (depending on use case), splaying on removal won't help search performance.
Experimental "findParent" to find the parent of a node also added (though I haven't written tests for it separately -- it is used in removeNode for the case that the removed node is a leaf).