Search API, UI and their integration #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@D-Ne0 Please rebase your codebase on top of latest master. |
|
Integrated front-end code with API. |
|
Closing this as the changes have been pulled in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull doesn't contain code to authorizes API calls. Apart from that, it returns search results as expected :)
I was not sure which could be the best authorization mechanism, so I didn't implement it. Also, it is not possible to use Meteor.user() on server side iron router for authorization. See yourself: http://stackoverflow.com/questions/20219572/meteor-user-on-iron-router-server-side
PS: I have rebased ESIntegration branch on search_api.