Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: adjust parent span's startTime when child span's startTime e… #53

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cindyliu-tec
Copy link

adjust parent span's startTime when child span's startTime early than it's parent span

@bboreham
Copy link
Collaborator

Thanks for the PR. Could you share a little how this situation comes up, why you care about it, etc.?

@cindyliu-tec
Copy link
Author

Thanks for the PR. Could you share a little how this situation comes up, why you care about it, etc.?

I want it seem more like a normal request trace, a father span end when it's last child span end. if there still have child span being processing, but upper level span already ended, I think it looks weird. for example, when deployment-controller receive a mission to deploy a workload, people instinctively fell the mission only end when the workload is deployed successful or failed, instead of just assign tasks to replicaset-controller then itself end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants