fix setup-web2py-ubuntu.sh and setup-web2py-debian.sh #2063
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2063 +/- ##
==========================================
+ Coverage 49.33% 54.26% +4.93%
==========================================
Files 44 43 -1
Lines 15923 17871 +1948
Branches 3771 4239 +468
==========================================
+ Hits 7855 9698 +1843
+ Misses 6957 6920 -37
- Partials 1111 1253 +142 |
There was a problem hiding this comment.
Can we upgrade the Python version to Python 3? Python 2.5 has long since reached its end of life, and even 2.7 is nearing its own EOL in less than 365 days.
| apt-get -y install ssh | ||
| apt-get -y install zip unzip | ||
| apt-get -y install tar | ||
| apt-get -y install openssh-server | ||
| apt-get -y install build-essential | ||
| apt-get -y install python | ||
| #apt-get -y install python2.5 | ||
| apt-get -y install ipython |
There was a problem hiding this comment.
| apt-get -y install ipython | |
| apt-get -y install ipython3 |
There was a problem hiding this comment.
never tried web3py with ipython3, had someone tried it ?
|
agree, no worries to use python3 as a standard since python 2 EOL will be in 2020, perhaps update the others scripts (ubuntu, centos, fedora) too ? |
|
Definitely -- the more we can get upgraded to Python 3, the better support we'll have down the line! |
Co-Authored-By: sugizo <sugizo@users.noreply.github.com>
Co-Authored-By: sugizo <sugizo@users.noreply.github.com>
Co-Authored-By: sugizo <sugizo@users.noreply.github.com>
Co-Authored-By: sugizo <sugizo@users.noreply.github.com>
| Require all granted | ||
| </Directory> | ||
|
|
||
| <Location /admin> |
There was a problem hiding this comment.
not sure, should not removed that <Location /admin>, or it will thrown an error
scripts/setup-web2py-debian.sh
Outdated
| apt-get -y install ipython | ||
| apt-get -y install python-dev | ||
| apt-get -y install postgresql | ||
| apt-get -y install apache2 | ||
| apt-get -y install libapache2-mod-wsgi | ||
| apt-get -y install python-psycopg2 | ||
| apt-get -y install python2.5-psycopg2 |
There was a problem hiding this comment.
there is not pyhton2.7-psycopg2?
There was a problem hiding this comment.
last checked the package on 2019.05.27 on docker debian container
# apt search psycopg2
Sorting... Done
Full Text Search... Done
python-psycogreen/stable 1.0-1 all
psycopg2 integration with coroutine libraries
python-psycopg2/stable 2.6.2-1 amd64
Python module for PostgreSQL
python-psycopg2-dbg/stable 2.6.2-1 amd64
Python module for PostgreSQL (debug extension)
python-psycopg2-doc/stable 2.6.2-1 all
Python module for PostgreSQL (documentation package)
so it the package name should be : python-psycopg2
not python2.5-psycopg2 nor pyhton2.7-psycopg2
| @@ -25,17 +25,20 @@ read CONFIRM | |||
| echo "installing useful packages" | |||
| echo "==========================" | |||
| apt-get update | |||
| apt-get -y install sudo | |||
There was a problem hiding this comment.
it thrown an error when execute in docker container image because of minimal installed base system, think there is another option to cover the error, either get the user to installed sudo package first before execute the install script or put the sudo package on install scripts like the proposed change script
ref:
https://groups.google.com/forum/#!topic/web2py/IFasLOdWsbI
ubuntu add package sudo as it's prerequisites to run from user
debian same like ubuntu script
all tested on docker and work
ref
https://groups.google.com/forum/#!topic/web2py/IFasLOdWsbI