This repository has been archived by the owner on Jan 16, 2018. It is now read-only.
windows workflow improvements #101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use git's bundled ssh if ssh not found
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on windows automatically elevate to admin privileges if needed and attempt to use git's bundled ssh if ssh not found
this makes the
vagrant upandvagrant sshcommands work without requiring extra effort from the user on a windows hostWindows doesn't ship with a compatible ssh executable. Git installer on windows doesn't add git bin dir to the system path by default because it causes conflicts with windows built ins. The batch script makes git's bundled ssh usable in the vagrant context in this case. It defaults to ssh on the path if there is one
The vagrant.bat wrapper handles automatic privilege escalation which is necessary on windows to have the permissions to create symlinks in the shared folder.
This currently uses the command prompt for windows it opens. A future commit could use the command prompt or power shell depending on which the user is calling from.