Skip to content

Commit

Permalink
Add byte typedef in Kalyna's anonymous namespace to avoid issues with…
Browse files Browse the repository at this point in the history
… globally scoped byte

This check-in supports Romain Geissler's work on cleaning up our use of ::byte when it collides with std::byte. Regardless of what happens, such as removing ::byte and adding CryptoPP::byte, providing the typedef here makes Kalyna immune to the outside changes. Also see Pull Request 437 and 438.
  • Loading branch information
noloader committed Jul 16, 2017
1 parent 32f715f commit fe63795
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions kalyna.cpp
Expand Up @@ -31,6 +31,9 @@ NAMESPACE_END

ANONYMOUS_NAMESPACE_BEGIN

// The typedef here is to sidestep problems with byte in the global namespace
typedef unsigned char byte;

using CryptoPP::word64;
using CryptoPP::KalynaTab::T;
using CryptoPP::KalynaTab::S;
Expand Down

1 comment on commit fe63795

@noloader
Copy link
Collaborator Author

@noloader noloader commented on fe63795 Jul 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also see PR 437 and PR 438.

Please sign in to comment.