Some comments

git-svn-id: http://anonsvn.jboss.org/repos/weld/ri/trunk@177 1c488680-804c-0410-94cd-c6b725194a0e
weld · Oct 27, 2008 · 099167c · 099167c
1 parent 4fd19e8
commit 099167c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/webbeans-ri/src/main/java/org/jboss/webbeans/event/EventImpl.java b/webbeans-ri/src/main/java/org/jboss/webbeans/event/EventImpl.java
@@ -14,7 +14,6 @@
 import javax.webbeans.DuplicateBindingTypeException;
 import javax.webbeans.Event;
 import javax.webbeans.Observer;
-import javax.webbeans.TypeLiteral;
 import javax.webbeans.manager.Manager;
 
 /**
@@ -43,6 +42,7 @@ public class EventImpl<T> implements Event<T>
     */
    public void setEventBindings(Annotation... eventBindings)
    {
+      // TODO Use constructor injection
       Set<Annotation> newEventBindings = new HashSet<Annotation>();
       addAnnotationBindings(newEventBindings, eventBindings);
       this.eventBindings = newEventBindings;

diff --git a/webbeans-ri/src/main/java/org/jboss/webbeans/event/EventObserver.java b/webbeans-ri/src/main/java/org/jboss/webbeans/event/EventObserver.java
@@ -20,6 +20,9 @@
  */
 public class EventObserver<T>
 {
+
+   // TODO This probably should be an injectable or annotated item
+
    private final Class<T> eventType;
    private final Annotation[] eventBindings;
    private final Observer<T> observer;
@@ -75,6 +78,7 @@ public final Observer<T> getObserver()
     */
    public boolean isObserverInterested(Annotation... bindings)
    {
+      // TODO This logic needs to be in injectable
       boolean result = true;
       // Check each binding specified by this observer against those provided
       if (this.eventBindings != null)
@@ -87,6 +91,7 @@ public boolean isObserverInterested(Annotation... bindings)
                int eventBindingIndex = bindingsArray.indexOf(annotation);
                if (eventBindingIndex >= 0)
                {
+                  // TODO Use annotation equality
                   result = annotationsMatch(annotation, bindingsArray.get(eventBindingIndex));
                } else
                {
@@ -105,6 +110,7 @@ public boolean isObserverInterested(Annotation... bindings)
     * @param annotation The first annotation to compare
     * @param annotation2 The second annotation to compare
     * @return
+    * 
     */
    private boolean annotationsMatch(Annotation annotation,
          Annotation annotation2)
@@ -131,4 +137,6 @@ private boolean annotationsMatch(Annotation annotation,
       return result;
    }
 
+   // TODO Implement equals and hashCode
+
 }