unify addBean, finish BeanIdStore

git-svn-id: http://anonsvn.jboss.org/repos/weld/ri/trunk@2957 1c488680-804c-0410-94cd-c6b725194a0e
weld · Jul 2, 2009 · 8c7626f · 8c7626f
1 parent 486b025
commit 8c7626f
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 23 deletions.
diff --git a/impl/src/main/java/org/jboss/webbeans/BeanIdStore.java b/impl/src/main/java/org/jboss/webbeans/BeanIdStore.java
@@ -103,7 +103,7 @@ public boolean contains(Integer id)
       return beans.containsKey(id);
    }
 
-   public Integer get(Bean<?> bean, BeanManagerImpl manager)
+   public Integer put(Bean<?> bean, BeanManagerImpl manager)
    {
       if (beans.inverse().containsKey(bean))
       {

diff --git a/impl/src/main/java/org/jboss/webbeans/BeanManagerImpl.java b/impl/src/main/java/org/jboss/webbeans/BeanManagerImpl.java
@@ -528,21 +528,32 @@ protected void addWebBeansDeploymentTypes()
 
    public void addBean(Bean<?> bean)
    {
-      synchronized (bean)
-      {
          if (beans.contains(bean))
          {
             return;
          }
-         beanResolver.clear();
-         beans.add(bean);
+         if (bean instanceof NewEnterpriseBean)
+         {
+            NewEnterpriseBean<?> newEnterpriseBean = (NewEnterpriseBean<?>) bean;
+            newEnterpriseBeans.put(newEnterpriseBean.getType(), newEnterpriseBean);
+         }
+         else if (bean instanceof DecoratorBean)
+         {
+            decorators.add((DecoratorBean<?>) bean);
+         }
+         if (bean instanceof RIBean)
+         {
+            RIBean<?> riBean = (RIBean<?>) bean;
+            riBeans.put(riBean.getId(), riBean);
+         }
+         getServices().get(BeanIdStore.class).put(bean, this);
          registerBeanNamespace(bean);
          for (BeanManagerImpl childActivity : childActivities)
          {
             childActivity.addBean(bean);
          }
-         return;
-      }
+         this.beans.add(bean);
+         beanResolver.clear();
    }
 
    public <T> Set<Observer<T>> resolveObservers(T event, Annotation... bindings)
@@ -720,22 +731,6 @@ public Set<Bean<?>> getInjectableBeans(InjectionPoint injectionPoint)
       }
    }
 
-   public void addRIBean(RIBean<?> bean)
-   {
-      if (bean instanceof NewEnterpriseBean)
-      {
-         newEnterpriseBeans.put(bean.getType(), (EnterpriseBean<?>) bean);
-      }
-      if (bean instanceof DecoratorBean)
-      {
-         decorators.add((DecoratorBean<?>) bean);
-      }
-      riBeans.put(bean.getId(), bean);
-      registerBeanNamespace(bean);
-      this.beans.add(bean);
-      beanResolver.clear();
-   }
-
    protected void registerBeanNamespace(Bean<?> bean)
    {
       if (bean.getName() != null && bean.getName().indexOf('.') > 0)
@@ -1377,4 +1372,12 @@ public int compare(Bean<? extends X> o1, Bean<? extends X> o2)
       return sortedBeans.last();
    }
 
+   /**
+    * @param bean
+    */
+   public void addRIBean(RIBean<?> bean)
+   {
+      addBean(bean);
+   }
+
 }