WELD-506 Added proxying of private methods

weld · May 28, 2010 · f0c1da9 · f0c1da9
1 parent 8749a47
commit f0c1da9
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/impl/src/main/java/org/jboss/weld/bean/proxy/ProxyFactory.java b/impl/src/main/java/org/jboss/weld/bean/proxy/ProxyFactory.java
@@ -402,6 +402,20 @@ protected void addMethodsFromClass(CtClass proxyClassType)
                proxyClassType.addMethod(CtNewMethod.make(method.getReturnType(), method.getName(), method.getParameterTypes(), method.getExceptionTypes(), createInterceptorBody(method), proxyClassType));
             }
          }
+         // Also add all private methods from the class hierarchy
+         CtClass superClass = proxyClassType.getSuperclass();
+         while (!superClass.getName().equals("java.lang.Object"))
+         {
+            for (CtMethod method : superClass.getDeclaredMethods())
+            {
+               if (Modifier.isPrivate(method.getModifiers()) && !method.getDeclaringClass().getName().equals("java.lang.Object"))
+               {
+                  log.trace("Adding method " + method.getLongName());
+                  proxyClassType.addMethod(CtNewMethod.make(method.getReturnType(), method.getName(), method.getParameterTypes(), method.getExceptionTypes(), createInterceptorBody(method), proxyClassType));
+               }
+            }
+            superClass = superClass.getSuperclass();
+         }
       }
       catch (Exception e)
       {

diff --git a/tests/src/test/java/org/jboss/weld/tests/event/EventQualifierTest.java b/tests/src/test/java/org/jboss/weld/tests/event/EventQualifierTest.java
@@ -24,7 +24,7 @@
 public class EventQualifierTest extends AbstractWeldTest
 {
 
-   @Test(description="WELD-226", groups="broken")
+   @Test(description="WELD-226")
    public void testDefaultQualifierNotRequired()
    {
       Bar bar = getReference(Bar.class);

diff --git a/tests/src/test/java/org/jboss/weld/tests/proxy/observer/ObserverInjectionTest.java b/tests/src/test/java/org/jboss/weld/tests/proxy/observer/ObserverInjectionTest.java
@@ -8,7 +8,7 @@
 public class ObserverInjectionTest extends AbstractWeldTest
 {
 
-   @Test(description="WELD-535", groups="broken")
+   @Test(description="WELD-535")
    public void testInjectionHappens()
    {
       SampleObserver sampleObserver = getReference(SampleObserver.class);