Weld709

[mbogoevici]

move tests from EARs to WARs and allow them to execute on JBAS trunk (with hierarchical deployments)

[pmuir]

Running with this patch rebased onto master I still see 4 errors in arquillian-tests

testCreateSFSB(org.jboss.weld.tests.enterprise.lifecycle.EnterpriseBeanLifecycleTest)      

testAfterTransactionCompletionObserver(org.jboss.weld.tests.event.observer.transactional.TransactionalObserversTest)

testAfterTransactionSuccessObserver(org.jboss.weld.tests.event.observer.transactional.TransactionalObserversTest)

testAfterTransactionFailureObserver(org.jboss.weld.tests.event.observer.transactional.TransactionalObserversTest)

[pmuir]

What build of AS should I be running with?

[mbogoevici]

I tried it against both the weld-integration-snapshot (either the last or the second-last revision, depending whether the patch for jboss-interceptor 2 is pulled into weld-core or not) or trunk - when I used cherry pick on top of the 1.1.0.Batch1 branch. Either case, it makes sense only when used against a branch of JBAS that uses hierarchical deployments (although that shouldn't make a difference, just that in a flat deployment scenario there's no benefit in doing this). Is it possible that we hit a case where those tests are failing for another cause - i.e do those tests succeed without applying the patch, or they don't run before applying the patch and now that they run we start seeing errors?

Let me know what your test config is and I'll try to reproduce this locally.

[pmuir]

master of Weld, with patch rebased on top, running without hierarchical deployments. All tests were passing before I applied the patch (though if you altered any test groups or ignores then that would change things).

Will try to run against the penultimate rev of weld-integration-snapshot now.

[pmuir]

Whatever I do I can't get these three tests to pass now:

Tests in error:
org.jboss.weld.tests.proxy.privateconstructor.ProxyConstructorTest
org.jboss.weld.tests.proxy.weld56.ProxyTest
org.jboss.weld.tests.proxy.weld56.ProxyTest

Steps:

1. create a branch from master
2. merge in weld709, weld-683 and jbas-weld-shared-update
3. rebase against master
4. run mvn install
5. build jboss as from https://svn.jboss.org/repos/jbossas/branches/weld-snapshot-integration@108504
6. run mvn clean verify -Dincontainer, pointing to the jboss as just built

[pmuir]

Error is
DEPLOYMENTS IN ERROR:
Deployment "vfs:///Users/pmuir/workspace/weld/core/tests-arquillian/test.war_WeldBootstrapBean" is in error due to the following reason(s): org.jboss.weld.exceptions.UnproxyableResolutionException: WELD-001435 Normal scoped bean class org.jboss.weld.tests.proxy.weld56.Foo is not proxyable because it has no no-args constructor.,

[pmuir]

I think the problem is likely I'm not pulling in enough things or sth. Can you write exactly what I need to do to get everything up to where it needs to be? E.g. do I need to pull in API updates too?

[pmuir]

This is merged in.

I added a commit to exclude the proxy tests, and also a commit to exclode CDITCK-182.