Weld 732

[ivaynberg]

integration tests fail because i believe there is a bug in the tck.

test fails in EventTest:149
147: StockPrice price = new StockPrice();
148: Set<ObserverMethod<? super StockPrice>> observers = getCurrentManager().resolveObserverMethods(price);
149: assert observers.size() == 1;

the one and only one expected observer method is:
StockWatcher#public void observeStockPrice(@observes StockPrice price)

however, according to section 4.2 of the spec:
If X declares an initializer, non-static observer, @PostConstruct or @PreDestroy method x() then
Y inherits x() if and only if neither Y nor any intermediate class that is a subclass of X and a
superclass of Y overrides the method x().
so the two observer methods from IntermediateStockWatcher and IndirectStockWatcher subclasses of StockWatcher should also be considered.

[pmuir]

I don't see any observer methods on IntermediateStockWatcher or IndirectStockWatcher

[ivaynberg]

both of those extend StockWatcher so they should inherit the observer methods. which is the point of WELD-732.

[pmuir]

oic sorry

[pmuir]

Please can you file an issue in CDITCK so that we can get the TCK fixed.

[ivaynberg]

created CDITCK-186

[pmuir]

Ok, issue in TCK confirmed, please update the exclude list in Weld so that the test suite passes.

[ivaynberg]

a question about ObserverMethodOnIncorrectBeanTest TCK test...it ignores the observer method on NonManagedBean class because it doesnt have a compatible constructor to be instantiated. what if there is a producer method for it? is it then considered a manged bean and should the observer method on it be included?

[pmuir]

No.

[pmuir]

A producer method doesn't make a class that is not a bean a bean, it makes the result of calling the method a bean.

[ivaynberg]

is there an easy way to check if an instance of WeldClass is a managed bean? or do those only get created for managed beans?

[pmuir]

We currently don't have a static util method for this that is publically available. Moving org.jboss.weld.bootstrap.AbstractBeanDeployer.isTypeManagedBeanOrDecoratorOrInterceptor(WeldClass<?>) to Beans would be the correct thing to do, it does mostly the right thing (though as the name says, it also checks for interceptors and decorators, so we would want to split that func out).

[mbogoevici]

pulled