WELDX-179 introduce @Qualified annotation #25
Conversation
- introduce the @qualified annotation to be used with @nAmed to assign a qualified name to bean - add tests - introduce default constructor for NamedLiteral - add method to Properties to check if method is an accessor method
|
Qualify is a term already used in cdi, so I think we need to use another word, perhaps a synonym. |
|
True, qualify is used in CDI. On the other hand, "fully-qualified class name" is a well known term in Java. Regardless, I can offer some other ideas:
I've also added support for a target namespace via a class reference (the package of that target class). I figured this would be useful for people that want to use a fixed top-level namespace despite having subpackages. |
|
Maybe @fullyqualified? |
|
Also can you split out changes for this issue vs structural changes to the class. Additionally, we should support @qualified (or whatever it becomes) on packages. |
- refactor @qualified to @fullyqualified - honor @fullyqualified at the package-level (fully) - add test for @fullyqualified at package level - add more API docs to @fullyqualified
|
I had support on packages in one of the previous commits, but only on packages that also had @nAmed. I added support for it at the package level independent of @nAmed at the package level. Just refactored to use @fullyqualified. Seems to be a nice fit to me. I don't mean to sound like I'm grumbling, but the main reason there are structural changes was to make this easier to code. If I have to separate the two, then I need to do the work twice. If you think that's really necessary, I'll bite my lip and just do it. |
|
Since we seem to be rolling with this feature, I'll go ahead and add the section to the docs, mostly from the api doc I already wrote. |
|
Rebased to one commit and closed. |
|
Pete, sorry for not getting a chance to fix the commits as you request. I've been meaning to get to it, but I've just been short on time. Thanks for merging it in. |
Additionally made some optimizations in CoreExtension and added Properties#isProperty(Method)