Skip to content
This repository has been archived by the owner on Sep 2, 2019. It is now read-only.

Update version of hiredis to be compatible with Ruby 2.2+ #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AmarHV
Copy link

@AmarHV AmarHV commented Dec 3, 2015

In reference to #61, this updates the hiredis to 0.6.0. dependency to be compatible with Ruby 2.2+ and stop the undefined symbol: rb_thread_select error.

@whoahbot
Copy link
Owner

whoahbot commented Dec 7, 2015

Hi AmarHV,

Thank you for the pull request. I pulled this branch down locally, but have been seeing test failures that may or may not be unrelated.

Do the tests pass for you locally? If so, I'd be happy to merge this and push up a new version of the gem.

@AmarHV
Copy link
Author

AmarHV commented Dec 7, 2015

Hi,

On the current version, I couldn't run the tests because I got an error about rspec-core not being installed. I bumped the rspec version to 2.4.0, and the specs ran, but they got the same errors as what I am getting on my PR.

I'm not sure if this is an error with rspec, or just something that was already on the branch. It doesn't seem that my PR has introduced new errors.

Have you seen this before?

@whoahbot
Copy link
Owner

whoahbot commented Dec 7, 2015

Can you gist the errors that you are getting so that I can compare? I haven't seen the errors I'm getting when running the specs before, but I haven't run them in some time.

@AmarHV
Copy link
Author

AmarHV commented Dec 7, 2015

@whoahbot
Copy link
Owner

whoahbot commented Dec 7, 2015

I'm seeing the same failures that you are, and one other that may be unrelated.

I doubt that these failures are directly related to the patch you submitted, but they seem to be legit. I'll need to investigate further before I merge your PR and push up a new gem.

Thank you again for submitting a PR! It is greatly appreciated.

@AmarHV
Copy link
Author

AmarHV commented Dec 8, 2015

Okay, no problem, thanks for making the gem :)

On 8 Dec 2015, at 11:25 AM, Dan Herrera notifications@github.com wrote:

I'm seeing the same failures that you are, and one other that may be unrelated.

I doubt that these failures are directly related to the patch you submitted, but they seem to be legit. I'll need to investigate further before I merge your PR and push up a new gem.

Thank you again for submitting a PR! It is greatly appreciated.


Reply to this email directly or view it on GitHub #62 (comment).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants