-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trading #6419
Open
bunnybot
wants to merge
37
commits into
master
Choose a base branch
from
mirror/Nordfriese/widelands/trading
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Trading #6419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assigned to Nordfriese |
bunnybot
added
enhancement
New feature or request
tribes
Buildings, wares, workers, ships, ...
balancing & gameplay
Tribes' statistics & mechanics
economy
Ware priority & transport, worker creation & assignment, requests & supplies, trading
labels
Mar 25, 2024
bunnybot
added
ci:success
CI checks succeeded
and removed
ci:success
CI checks succeeded
labels
Apr 21, 2024
bunnybot
added
ci:success
CI checks succeeded
and removed
ci:success
CI checks succeeded
labels
Apr 30, 2024
bunnybot
added
ci:success
CI checks succeeded
and removed
ci:success
CI checks succeeded
labels
May 12, 2024
bunnybot
added
ci:success
CI checks succeeded
and removed
ci:success
CI checks succeeded
labels
May 19, 2024
bunnybot
added
ci:success
CI checks succeeded
and removed
ci:success
CI checks succeeded
labels
May 20, 2024
bunnybot
added
ci:success
CI checks succeeded
and removed
ci:success
CI checks succeeded
labels
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
balancing & gameplay
Tribes' statistics & mechanics
ci:success
CI checks succeeded
economy
Ware priority & transport, worker creation & assignment, requests & supplies, trading
enhancement
New feature or request
tribes
Buildings, wares, workers, ships, ...
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored from Codeberg
Created on Mon Mar 25 20:16:58 CET 2024 by Benedikt Straub (Nordfriese)
Type of change
New feature
Issue(s) closed
Fixes #1863
How it works
So, here's what I want to be the big new feature for v1.3 :)
The long-existing trading system by SirVer is now completed and usable with a user interface, saveloading support, Lua API, and tribe-independent generalization.
Trades are conducted via named markets. To propose a trade to another player, open a market's window, select what wares you want to send and receive, and send out a trade offer.
Be sure to select first the player you want to trade with and then configure the wares, since only wares used by both players' respective tribe may be traded.
Your trade offers can be seen in the diplomacy window. There you can accept or reject trade offers. You need a market to accept an offer.
Once the offer has been accepted, the market requests the wares and carriers and the two markets will start exchanging wares.
All trading is land-based; only markets on the same island can trade with each other.
Possible regressions
Desyncs, crashes, race conditions, …
Screenshots
Configuring a trade:
Offered trade:
Proposed trade:
Active trade:
Caravan of traders:
Additional context
There are a number of rough edges, which is to be expected in such a feature. Some things that I especially miss in the current state of the branch are:
But I would consider all these minor points (except AI handling, which will be a very big point…) and would prefer to have this feature early in the release cycle, and add more functionality in smaller branches.