Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making some regression errors and linting issues #4

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

wisemuffin
Copy link
Owner

oh wow i am gonna get in trouble.
making some regression errors and linting issues
I hope no one checks my PR before it goes into prod

Copy link

@datafold datafold bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base branch Pull Request branch
main (8d271cc) demo/ci_cd_linting_testing_regression (0e9ade3)
 Data Diffs of tables modified in this pull request:
JAFFLE_SHOP_SL.PROD.ORDERS
Primary keys ORDER_ID
DIFFERENCES
 Columns with changed type/order: 1
column change
ORDER_COST Reordered
 1 column(s) with differing values
column number of rows
IS_DRINK_ORDER 46,651  78.2%
 
NO DIFFERENCES
Total rows 59,652
Total columns 9
Common unique PKs 59,652
Added/removed rows 0
Rows with NULL PKs 0
Rows with duplicate PKs 0
View details →
Skipped Data Diffs of downstream tables: 1 Add "datafold:diff-all-downstream" label to this pull request to diff all affected tables
jaffle_shop_sl.prod.customers (table) Run Data Diff →

Copy link

@datafold datafold bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base branch Pull Request branch
main (aac237f) demo/ci_cd_linting_testing_regression (2f3f41b)
 Data Diffs of tables modified in this pull request:
JAFFLE_SHOP_SL.PROD.ORDERS
Primary keys ORDER_ID
DIFFERENCES
 Columns with changed type/order: 2
column change
IS_DRINK_ORDER BOOLEAN → NUMBER(13,0)  Reordered
ORDER_COST Reordered
 
NO DIFFERENCES
Total rows 59,652
Total columns 9
Common unique PKs 59,652
Added/removed rows 0
Rows with NULL PKs 0
Rows with duplicate PKs 0
Columns with different values 0
View details →
Skipped Data Diffs of downstream tables: 1 Add "datafold:diff-all-downstream" label to this pull request to diff all affected tables
jaffle_shop_sl.prod.customers (table) Run Data Diff →

Copy link

@datafold datafold bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base branch Pull Request branch
main (aac237f) demo/ci_cd_linting_testing_regression (d9b3d10)
 Data Diffs of tables modified in this pull request:
JAFFLE_SHOP_SL.PROD.ORDERS
Primary keys ORDER_ID
DIFFERENCES
 Columns with changed type/order: 3
column change
IS_DRINK_ORDER BOOLEAN → NUMBER(13,0)  Reordered
IS_FOOD_ORDER BOOLEAN → NUMBER(13,0)  
ORDER_COST Reordered
 
NO DIFFERENCES
Total rows 59,652
Total columns 9
Common unique PKs 59,652
Added/removed rows 0
Rows with NULL PKs 0
Rows with duplicate PKs 0
Columns with different values 0
View details →
Skipped Data Diffs of downstream tables: 1 Add "datafold:diff-all-downstream" label to this pull request to diff all affected tables
jaffle_shop_sl.prod.customers (table) Run Data Diff →

Copy link

@datafold datafold bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base branch Pull Request branch
main (aac237f) demo/ci_cd_linting_testing_regression (ed19cd2)
 Data Diffs of tables modified in this pull request:
JAFFLE_SHOP_SL.PROD.ORDERS
Primary keys ORDER_ID
DIFFERENCES
 Columns with changed type/order: 3
column change
IS_DRINK_ORDER BOOLEAN → NUMBER(13,0)  Reordered
IS_FOOD_ORDER BOOLEAN → NUMBER(13,0)  
ORDER_COST Reordered
 1 column(s) with differing values
column number of rows
ORDER_COST 58,533  98.1%
 
NO DIFFERENCES
Total rows 59,652
Total columns 9
Common unique PKs 59,652
Added/removed rows 0
Rows with NULL PKs 0
Rows with duplicate PKs 0
View details →
Skipped Data Diffs of downstream tables: 1 Add "datafold:diff-all-downstream" label to this pull request to diff all affected tables
jaffle_shop_sl.prod.customers (table) Run Data Diff →

Copy link

@datafold datafold bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base branch Pull Request branch
main (aac237f) demo/ci_cd_linting_testing_regression (5b88c85)
 Data Diffs of tables modified in this pull request:
JAFFLE_SHOP_SL.PROD.ORDERS
Primary keys ORDER_ID
main demo/ci_cd_linting_t...
DIFFERENCES
  Total rows 59,652 100 -99.8%
 Columns with changed type/order: 3
column change
IS_DRINK_ORDER BOOLEAN → NUMBER(13,0)  Reordered
IS_FOOD_ORDER BOOLEAN → NUMBER(13,0)  
ORDER_COST Reordered
  Exclusive PKs 59,552 0
 1 column(s) with differing values
column number of rows
ORDER_COST 99  99.0%
 
NO DIFFERENCES
Total columns 9
Common unique PKs 100
Rows with NULL PKs 0
Rows with duplicate PKs 0
View details →
Skipped Data Diffs of downstream tables: 1 Add "datafold:diff-all-downstream" label to this pull request to diff all affected tables
jaffle_shop_sl.prod.customers (table) Run Data Diff →

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant