Handle leading zeros and improve UX with default input fields #116

marcoancona · 2018-11-05T12:33:38Z

New proposal, using normal input field, instead of type=number.
Advantages:

no need for additional span to handle leading zeros, while supporting all major browsers
update on ArrowUp/ArrowDown easily handled at parent level ('DateInput`), allowing for infinite date sequences (ie. 12-31-2018 -> focus on day 31 -> ArrowUp -> 01-01-2019)
validation on minDate/maxDate also handled in DateInput, which simplifies the logic of DayInput, MonthInputandYearInput` quite a bit

What do you think?

marcoancona added 2 commits November 5, 2018 13:01

wip: replace input type=number with default input

a1b8b7c

add minDate/maxDate validation

0be83a5

marcoancona mentioned this pull request Nov 5, 2018

Improved handling of leading zeros, length limit and UX #115

Closed

adding prepare script

f2977ee

wojtekmaj force-pushed the master branch from 18e3632 to f89c646 Compare March 28, 2019 19:23

wojtekmaj force-pushed the master branch 2 times, most recently from 10f9d1e to 8e53e44 Compare July 8, 2019 17:29

wojtekmaj force-pushed the master branch from 6bbad39 to 70cfa40 Compare January 6, 2021 21:33

wojtekmaj force-pushed the master branch from e75768c to 369959d Compare January 29, 2021 19:05

wojtekmaj force-pushed the master branch from e888875 to b52b0dd Compare June 25, 2021 08:57

wojtekmaj force-pushed the main branch from 747cbd4 to 2c2a2fc Compare January 19, 2022 16:00

wojtekmaj force-pushed the main branch from 0502380 to e77d1d2 Compare January 29, 2022 06:43

wojtekmaj force-pushed the main branch 3 times, most recently from bdde3a5 to dc151e8 Compare March 24, 2022 08:40

wojtekmaj force-pushed the main branch 2 times, most recently from c4d58cf to 6dc7a09 Compare September 6, 2022 09:42

wojtekmaj force-pushed the main branch 8 times, most recently from ab5a30b to ff3a3ee Compare October 24, 2022 15:33

wojtekmaj force-pushed the main branch 5 times, most recently from 00ed12d to eb83192 Compare November 7, 2022 11:13

wojtekmaj force-pushed the main branch 5 times, most recently from 8182ad3 to 21af20c Compare November 7, 2022 12:58

wojtekmaj force-pushed the main branch 3 times, most recently from e1c7dc5 to a524886 Compare January 4, 2023 23:23

wojtekmaj force-pushed the main branch 2 times, most recently from 98e1adb to e253cd3 Compare March 2, 2023 08:43

wojtekmaj force-pushed the main branch from b9ad093 to 14026c5 Compare March 26, 2023 18:09

wojtekmaj force-pushed the main branch 2 times, most recently from 0b4cd33 to 9dfdb34 Compare April 5, 2023 11:00

wojtekmaj force-pushed the main branch from b825ffb to b26ca7a Compare May 28, 2023 15:05

wojtekmaj force-pushed the main branch 2 times, most recently from c1a58a8 to 84b1863 Compare July 21, 2023 18:59

wojtekmaj force-pushed the main branch 2 times, most recently from 37e50fb to 5584926 Compare October 23, 2023 10:20

wojtekmaj force-pushed the main branch 2 times, most recently from 1fd7f2d to daa2c24 Compare November 2, 2023 07:30

wojtekmaj force-pushed the main branch from daa2c24 to 3e6f253 Compare November 8, 2023 11:45

wojtekmaj force-pushed the main branch from 4525a18 to 68881cf Compare November 22, 2023 12:28

wojtekmaj force-pushed the main branch from 28ebbd5 to 5effb02 Compare December 20, 2023 09:10

wojtekmaj force-pushed the main branch from fccf195 to 29db31c Compare April 26, 2024 12:40

Provide feedback