Fixed test: EuclideanShapeMetric expected scale-variant with alpha>0

wrongu · May 20, 2023 · 771cfc9 · 771cfc9
1 parent 459f4e9
commit 771cfc9
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/tests/metrics.py b/tests/metrics.py
@@ -106,22 +106,22 @@
      "translation-invariant": True,
      "scale-invariant": True,
      "affine-invariant": False},
-    # Also try p<n with alpha>0 (same invariances as previous one)
+    # Also try p<n with alpha>0 (no longer scale invariant without full whitening)
     {"metric": EuclideanShapeMetric(m=size_m, p=size_n//2, alpha=0.5),
      "name": f"ShapeMetric[0.50][{size_n//2}][euclidean].{size_m}",
      "expected-curvature": "positive",  # (!!) EuclideanShapeMetric curvature ≥ 0 when alpha < 1
      "high-rank-data": False,
      "rotation-invariant": True,
      "translation-invariant": True,
-     "scale-invariant": True,
+     "scale-invariant": False,  # (!!) EuclideanShapeMetric is not scale invariant when alpha > 0
      "affine-invariant": False},
     {"metric": EuclideanShapeMetric(m=size_m, p=size_n//2, alpha=1.0),
      "name": f"ShapeMetric[1.00][{size_n//2}][euclidean].{size_m}",
      "expected-curvature": "positive",  # (!!) EuclideanShapeMetric curvature ≥ 0 when alpha < 1
      "high-rank-data": False,
      "rotation-invariant": True,
      "translation-invariant": True,
-     "scale-invariant": True,
+     "scale-invariant": False,  # (!!) EuclideanShapeMetric is not scale invariant when alpha > 0
      "affine-invariant": False},
     # Shape metrics are also not affine-invariant when doing partial (alpha=0.5) or no (alpha=1.0) whitening
     {"metric": EuclideanShapeMetric(m=size_m, p=size_n, alpha=0.5),
@@ -130,15 +130,15 @@
      "high-rank-data": False,
      "rotation-invariant": True,
      "translation-invariant": True,
-     "scale-invariant": True,
+     "scale-invariant": False,  # (!!) EuclideanShapeMetric is not scale invariant when alpha > 0
      "affine-invariant": False},
     {"metric": EuclideanShapeMetric(m=size_m, p=size_n, alpha=1.0),
      "name": f"ShapeMetric[1.00][{size_n}][euclidean].{size_m}",
      "expected-curvature": "zero",
      "high-rank-data": False,
      "rotation-invariant": True,
      "translation-invariant": True,
-     "scale-invariant": True,
+     "scale-invariant": False,  # (!!) EuclideanShapeMetric is not scale invariant when alpha > 0
      "affine-invariant": False},
     # ...repeat the last 4 tests for the AngularShapeMetric
     {"metric": AngularShapeMetric(m=size_m, p=size_n, alpha=0.0),