Fix duplicate matches #646
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rico-chet
force-pushed
the
fix-duplicate-matches-with-legacy-py
branch
from
17f3295
to
6303abf
Compare
Closed
|
@wting can you approve this PR? The duplicate results are the only thing keeping me from switching back from Zoxide. |
The order of completion suggestions must be according to the weights, yet `set` is unordered. Thus, sorting needs to be performed after de-duplicating. Fixes wting#348
rico-chet
force-pushed
the
fix-duplicate-matches-with-legacy-py
branch
from
6303abf
to
54e5cb0
Compare
|
The first version had an issue that the results weren't sorted and thus one would typically jump to a random directory instead of the chosen one. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #348, also addressing a couple warnings I stumbled upon.