Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safeguard againsts lab errors in run creation #556

Open
mgcam opened this issue Feb 5, 2020 · 3 comments
Open

Safeguard againsts lab errors in run creation #556

mgcam opened this issue Feb 5, 2020 · 3 comments

Comments

@mgcam
Copy link
Member

mgcam commented Feb 5, 2020

Runs created in NPG, but then put on a different instrument.
Extension to the staging daemon to flag this king of swap: check that the instrument id in the RunParameters.xml is consistent with the value in the tracking database, also check the slot is correct. An error in a mismatch with existing in the database run folder name and glob will prevent assigning the same run id (as Experiment Name) to multiple runs

@mgcam mgcam changed the title safeguard againsts lab errors Safeguard againsts lab errors in run creation Jan 14, 2022
@dkj
Copy link
Member

dkj commented Jan 14, 2022

Also, limit these updates to runs which are in a run state "run pending" or "run in progress"?

@srl147
Copy link
Contributor

srl147 commented Jan 14, 2022

If the run id is specified incorrectly, in particular if the value entered corresponds to an older run or a run on a different instrument we should flag this as an error and not update the DB. We should be able to infer the correct date and instrument from the runfolder name.

As an example of what can go wrong, we had a recent run where the specified run id was for a run from 2011 which had been cancelled so we deleted the runfolder while the run was still in progress.

@mgcam
Copy link
Member Author

mgcam commented Feb 23, 2022

#669 resolves some of these problems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants