Validate id run #669
Merged
Validate id run #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…run before updating the DB
mgcam
requested changes
Feb 16, 2022
There was a problem hiding this comment.
We should be setting run folder name for run sin as many statuses as we can up to the point when run reaches 'analysis pending', otherwise we will will be unable to automatically delete cancelled and similar runs. Temporal indexes and run state comparison should be used for this purpose. We should not be updating very old runs, ie whenthe current status of the run is well in the past, say, over a week old.
dkj
reviewed
Feb 22, 2022
Co-authored-by: dkj <david.jackson@sanger.ac.uk>
mgcam
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.