Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTL purge schedule is never setup #412

Closed
lukecarbis opened this issue Apr 15, 2014 · 6 comments · Fixed by #418
Closed

TTL purge schedule is never setup #412

lukecarbis opened this issue Apr 15, 2014 · 6 comments · Fixed by #418
Labels

Comments

@lukecarbis
Copy link
Contributor

The schedule setup should run on every page load after the WP class object is setup, as per https://github.com/x-team/wp-stream/blob/master/includes/admin.php#L52.

However, it never seems to load. My guess is that changing the hook (maybe wp_loaded?) should fix the issue.

@fjarrett fjarrett added the bug label Apr 16, 2014
@lukecarbis
Copy link
Contributor Author

I can confirm that the wp_loaded hook will run the setup function, but I don't know why it's not running from wp. @fjarrett - is there a particular reason it's hooked in at wp?

@fjarrett
Copy link
Contributor

@lukecarbis Great question. I see it was introduced in #376 as a fix for #371.

@powelski Can you give us some background on this one?

@fjarrett
Copy link
Contributor

@lukecarbis So are you saying that using wp_loaded has been tested and works as expected?

@lukecarbis
Copy link
Contributor Author

Yes, on the condition that purge_schedule_setup is supposed to be run on every page load.

@fjarrett
Copy link
Contributor

@lukecarbis
Copy link
Contributor Author

Fixed by #418.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants