Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AJAX loading for user filter in list table #49

Closed
shadyvb opened this issue Dec 8, 2013 · 14 comments · Fixed by #236
Closed

AJAX loading for user filter in list table #49

shadyvb opened this issue Dec 8, 2013 · 14 comments · Fixed by #236
Assignees

Comments

@shadyvb
Copy link
Contributor

shadyvb commented Dec 8, 2013

Load users via AJAX, to accommodate for sites with thousands of users. Only use AJAX if user count is more than 50 user.

Using Select2 is preferred, due to the support/activity compared to chosen, and the built-in AJAX of course.

@shadyvb
Copy link
Contributor Author

shadyvb commented Jan 31, 2014

Closing issue, since user trigger has been AJAXified and pushed to master. Other bugs/fixes should be reported to a new issue.

@shadyvb shadyvb closed this as completed Jan 31, 2014
@fjarrett
Copy link
Contributor

@shadyvb I saw the word "trigger" and got confused with that other secret project we've been working on 😉

@shadyvb
Copy link
Contributor Author

shadyvb commented Jan 31, 2014

😳 Oooh! Sorry!
/me Reopening the issue.

@shadyvb shadyvb reopened this Jan 31, 2014
@fjarrett
Copy link
Contributor

Haha!

@powelski
Copy link

powelski commented Feb 5, 2014

@shadyvb @fjarrett Guys, how about limiting that dropdown to users that wrote at least one post, in addition of using Ajax here?

@fjarrett
Copy link
Contributor

fjarrett commented Feb 5, 2014

@powelski Well just because they haven't written a post doesn't mean they haven't performed other actions, like updating a widget or menu, for instance. So what we want to do is only load in users that have authored Stream records.

@powelski
Copy link

powelski commented Feb 5, 2014

@fjarrett That's true - at the time of writing I was focused on filtering posts, because of the "authors" word.

@fjarrett
Copy link
Contributor

fjarrett commented Feb 5, 2014

👍

@shadyvb
Copy link
Contributor Author

shadyvb commented Feb 20, 2014

Closing after PR merge.

@shadyvb shadyvb closed this as completed Feb 20, 2014
@faishal
Copy link
Contributor

faishal commented Apr 1, 2014

Ajax loading is not working in Author filter, its showing empty filter and list page also taking too much time to load.

stream-author-filter-issue

FYI : Site have 10K+ users

@fjarrett
Copy link
Contributor

fjarrett commented Apr 2, 2014

Thanks for checking this @faishal, I'm reopening the issue now.

@fjarrett fjarrett reopened this Apr 2, 2014
@fjarrett fjarrett added bug and removed enhancement labels Apr 2, 2014
@shadyvb
Copy link
Contributor Author

shadyvb commented Apr 12, 2014

Wondering if @powelski has noticed reopening of the issue.

@shadyvb
Copy link
Contributor Author

shadyvb commented Apr 23, 2014

@powelski I'm taking over this one, just in case you haven't noticed it.
/cc @fjarrett

@shadyvb shadyvb assigned shadyvb and unassigned powelski Apr 23, 2014
@shadyvb
Copy link
Contributor Author

shadyvb commented Apr 23, 2014

Fixed by #428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants