Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One notice for all missing db tables #506

Merged
merged 3 commits into from May 7, 2014
Merged

Conversation

shadyvb
Copy link
Contributor

@shadyvb shadyvb commented May 6, 2014

Before:
download

/cc @fjarrett

@shadyvb
Copy link
Contributor Author

shadyvb commented May 6, 2014

Worth noting that Stream should probably skip any queries if it found that its tables aren't there.

}
}
if ( $missing_tables ) {
$database_message .= sprintf( '%s %s', __( 'The following table(s) are not present in the WordPress database: ', 'stream' ), implode( ', ', $missing_tables ) );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use _n here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in aefb3a3

fjarrett added a commit that referenced this pull request May 7, 2014
@fjarrett fjarrett merged commit e40732d into develop May 7, 2014
@fjarrett fjarrett deleted the issue-no-tables-notice-fix branch May 7, 2014 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants