[Mono.Android] Dispose of the RunnableImplementor on error
#8907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: 3ce27c9 Commit 3ce27c9 had a TODO: > TODO: Address [^0] and dispose of the `RunnableImplementor` instance > when `View.Post()` returns `false`. > > [^0]: we leak if `View.post(Runnable)` returns *false*. The time is now! Review all `new RunnableImplementor(…, true)` calls, and if a "removable" `RunnableImplementor` is passed to a method which can return an error such as [`Handler.post()`][0] or [`View.post()`][1], dispose of the `RunnableImplementor` instance on error. [0]: https://developer.android.com/reference/android/os/Handler#post(java.lang.Runnable) [1]: https://developer.android.com/reference/android/view/View#post(java.lang.Runnable)
jonathanpeppers
approved these changes
Apr 26, 2024
grendello
added a commit
that referenced
this pull request
May 7, 2024
* main: Update README (#8913) Bumps to xamarin/java.interop@4e893bf (#8924) Bump to dotnet/installer@fa261b952d 9.0.100-preview.5.24253.16 (#8921) [Mono.Android] Dispose of the `RunnableImplementor` on error (#8907) Bump NDK to r26d (#8868) Bump to dotnet/installer@d301a122c4 9.0.100-preview.5.24229.2 (#8912) Localized file check-in by OneLocBuild Task (#8910) LEGO: Merge pull request 8909 [api-merge] Add `removed-since` info (#8897) Bump to xamarin/monodroid@9ca6d9f6 (#8895) [Xamarin.Android.Build.Tasks] fix detection of "Android libraries" (#8904)
grendello
added a commit
that referenced
this pull request
May 7, 2024
* main: Update README (#8913) Bumps to xamarin/java.interop@4e893bf (#8924) Bump to dotnet/installer@fa261b952d 9.0.100-preview.5.24253.16 (#8921) [Mono.Android] Dispose of the `RunnableImplementor` on error (#8907) Bump NDK to r26d (#8868)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: 3ce27c9
Commit 3ce27c9 had a TODO:
The time is now! Review all
new RunnableImplementor(…, true)calls, and if a "removable"RunnableImplementoris passed to a method which can return an error such asHandler.post()orView.post(), dispose of theRunnableImplementorinstance on error.Footnotes
we leak if
View.post(Runnable)returns false. ↩