CP-10203: XenAPI: api call for RDP on/off request

[huizh]

Xapi delegates the xenstore operations to xenopsd.

Signed-off-by: Hui Zhang hui.zhang@citrix.com

[simonjbeaumont]

This could return unimplemented like the s3suspend and s3resume. This is more accurate since returning unit is unclear whether it has done something or nothing.

[simonjbeaumont]

My guess is it's too late to change the name of this API call. To me, beg_rdp just sounds strange (almost unprofessional?). Anyway, it seems odd that this would take a boolean since begging for RDP has the connotation that you are asking for it to be enabled.

Apart from the aesthetics of this API design, it seems functionally sane.

[thomassa]

You can blame me for the name.
I agree that it sounds a little odd, but my thinking was that it's short and it makes it clear that we are only asking the guest to turn RDP on/off without any assurance of whether our request will be granted.

[huizh]

Thanks Simon for the comment on lib/xenops_server_skeleton.ml.
I've made update.

About the API name, Simon and Thomas, could you please let me know your opinion? To change it to a more suitable name (any suggestion?) or just keep it?
Thanks.

[robhoes]

Like @simonjbeaumont, I am not very comfortable with the name of the API call. This is even more important for the higher-level public API introduced in xapi-project/xen-api#2042. How about "request" rather than "beg"?

[huizh]

Thanks Rob for the suggestion.
Code has been updated accordingly.

[simonjbeaumont]

@huizh: sorry to mess you around, but did you see @djs55's comment here: xapi-project/xapi-project.github.io#12 (comment). He's suggesting a different API call name.

[huizh]

Thanks all for the comments.
There's discussion and decision made with xapi-project/xapi-project.github.io#12 (comment).
Based on that, we would keep the code.
Hope it's clear now.
Could you please correct me if there's any misunderstanding and review the code?

Much appreciate.

[huizh]

Thanks @thomassa