[osx] - add support for Xcode 8

[Memphiz]

This allows compiling with Xcode8 on either OSX 10.11 (El Capitan) or macOS 10.12 (Sierra).

thx @davilla for giving a hand.

@ksooo if you are still on el capitan - might want to test this out?

[mention-bot]

@Memphiz, thank you for improving kodi! According to the last 5 commits, we found the potential reviewers: @wsnipex, @davilla and @koying . Final approval needs to be given by the componenent maintainer.

[ksooo]

@ksooo if you are still on el capitan - might want to test this out?

sorry, updated to sierra yesterday

[koying]

Sure, mention-bot, I'm totally the king of xcode :)

[Memphiz]

@koying maybe you did something in depends configura.ac at some point ;)

[FernetMenta]

also on sierra already

[xhaggi]

I'm on el capitan but can't test it before tomorrow.

[Memphiz]

Well since i need this now that i have updated to xcode8 - lets ask jenkins build this please anyway and if @xhaggi has some sparetime left to test this in the next days - glad to have another ok (beside that building with xcode8 on 10.11 is only intermediate as most people will switch to sierra, when 12.1 comes out latest :) ).

[MrMC]

just a note, a build/run on sierra without this should work, but run that same build on el capitan and below and it will fail to run because of missing symbols.

[Memphiz]

yep that makes sense too :)

[fetzerch]

Fails for me with xcode7 on 10.11:

server-tools/instance-manager/Makefile.am:103: `%'-style pattern rules are a GNU make extension
/usr/bin/clang -I. -fheinous-gnu-extensions -no-cpp-precomp -arch x86_64 -mmacosx-version-min=10.8  -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk -isystem /Users/Shared/xbm
c-depends/macosx10.11_x86_64-target/include  -DHAVE_CONFIG_H -fheinous-gnu-extensions -no-cpp-precomp -arch x86_64 -mmacosx-version-min=10.8  -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/
MacOSX10.11.sdk -isystem /Users/Shared/xbmc-depends/macosx10.11_x86_64-target/include  -ggdb3 -Wall -W   -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes   -Wpointer-arith -Wbad-function-cast -Wnested-externs -fPIC -MT ne
ttle-internal.o -MD -MP -MF nettle-internal.o.d -c nettle-internal.c \
        && true
../lib/replace/replace.c:811:23: error: unknown type name 'clockid_t'; did you mean 'clock_t'?
int rep_clock_gettime(clockid_t clk_id, struct timespec *tp)
                      ^~~~~~~~~
                      clock_t
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/usr/include/sys/_types/_clock_t.h:30:33: note: 'clock_t' declared here
typedef __darwin_clock_t        clock_t;
                                ^
1 error generated.
The following command failed:
/usr/bin/clang -fheinous-gnu-extensions -no-cpp-precomp -arch x86_64 -mmacosx-version-min=10.8 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk -isystem /Users/Shared/xbmc-dep
ends/macosx10.11_x86_64-target/include -fno-common -I. -I/Users/jcf/develop/kodi/kodi/tools/depends/target/samba-gplv3/macosx10.11_x86_64-target/source3 -I/Users/jcf/develop/kodi/kodi/tools/depends/target/samba-gplv3/macosx10.11_x86_64-
target/source3/../lib/popt -I/Users/jcf/develop/kodi/kodi/tools/depends/target/samba-gplv3/macosx10.11_x86_64-target/source3/../lib/iniparser/src -Iinclude -I./include  -I. -I. -I./../lib/replace -I./../lib/tevent -I./librpc -I./.. -I./
../lib/talloc -I../lib/tdb/include -DHAVE_CONFIG_H  -fheinous-gnu-extensions -no-cpp-precomp -arch x86_64 -mmacosx-version-min=10.8 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.1
1.sdk -isystem /Users/Shared/xbmc-depends/macosx10.11_x86_64-target/include -Iinclude -I./include -I. -I. -I./../lib/replace -I./../lib/tevent -I./librpc -I./.. -I./../lib/popt  -I/Users/jcf/develop/kodi/kodi/tools/depends/target/samba-
gplv3/macosx10.11_x86_64-target/source3/lib -I.. -D_SAMBA_BUILD_=3 -D_SAMBA_BUILD_=3  -c ../lib/replace/replace.c -o ../lib/replace/replace.o
/Users/Shared/xbmc-depends/buildtools-native/bin/m4 ./asm.m4 machine.m4 config.m4 aes-decrypt-internal.asm >aes-decrypt-internal.s
/usr/bin/clang -I. -fheinous-gnu-extensions -no-cpp-precomp -arch x86_64 -mmacosx-version-min=10.8  -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk -isystem /Users/Shared/xbm
c-depends/macosx10.11_x86_64-target/include  -DHAVE_CONFIG_H -fheinous-gnu-extensions -no-cpp-precomp -arch x86_64 -mmacosx-version-min=10.8  -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/
MacOSX10.11.sdk -isystem /Users/Shared/xbmc-depends/macosx10.11_x86_64-target/include  -ggdb3 -Wall -W   -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes   -Wpointer-arith -Wbad-function-cast -Wnested-externs -fPIC -MT ae
s-decrypt-internal.o -MD -MP -MF aes-decrypt-internal.o.d -c aes-decrypt-internal.s
make[3]: *** [../lib/replace/replace.o] Error 1

[Memphiz]

@fetzerch thx will look into it tomorrow :)

[Jalle19]

Travis CI seems to support XCode 8 too, at least according to https://docs.travis-ci.com/user/osx-ci-environment/. Might be worth updating .travis.yml while you're at it.

[Memphiz]

@Jalle19 i don't see that travis builds for osx at all. So its not done just by "updating" something. No time to dive into travis-ci to add osx support to it.

[Jalle19]

Oh, I was mistaken since we do that for binary addons.

[Memphiz]

jenkins had the same issue @fetzerch and i was able to reproduce aswell. PR updated - new testbuild succeeded:

http://jenkins.kodi.tv/job/OSX-64/9309/

[fetzerch]

looks good here as well