New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] slider - add int/float support #11230
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronie
added
Type: Feature
non-breaking change which adds functionality
Component: Python
labels
Dec 20, 2016
phil65
reviewed
Dec 20, 2016
@@ -451,6 +451,34 @@ namespace XBMCAddon | |||
((CGUISliderControl*)pGUIControl)->SetPercentage(pct); | |||
} | |||
|
|||
int ControlSlider::getInt() | |||
{ | |||
return (pGUIControl) ? ((CGUISliderControl*)pGUIControl)->GetIntValue() : 0; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
phil65
reviewed
Dec 20, 2016
/// \ingroup python_xbmcgui_control_slider | ||
/// @brief \python_func{ setInt(value, min, delta, max) } | ||
///----------------------------------------------------------------------- | ||
/// Sets the value of the slider. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
thx! updated as suggested. |
jenkins build this please |
1 similar comment
jenkins build this please |
tamland
reviewed
Jan 11, 2017
{ | ||
if (pGUIControl) | ||
static_cast<CGUISliderControl*>(pGUIControl)->SetType(SLIDER_CONTROL_TYPE_INT); | ||
static_cast<CGUISliderControl*>(pGUIControl)->SetRange(min, max); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for slider controls, currently only the get/set percentage method is exposed to the python api.
this adds support for setting / getting float and int as well.
this allows addons to create a slider with (for instance) a range from -10 to 10.
@tamland / @phil65