Bitstream refactor / VC1Bitstream parser #11417

peak3d · 2017-01-10T21:48:29Z

Implement VC1-Packet Bitstream parser

Motivation and Context

VC-1 in mkv container sometimes have only DTS but no PTS values.
AML decoder needs from time to time a safe PTS value wich will be set on I-Frames.

This PR implements both I-Frame detection and Recovery point detection.

How Has This Been Tested?

Separate test environment

Types of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

FernetMenta · 2017-01-11T06:32:09Z

looks much cleaner now, thanks
(I have not looked at the details. I assume this has been tested and works)

peak3d · 2017-01-11T07:49:09Z

jenkins build this please, please

xbmc/utils/BitstreamConverter.cpp

          break;
        case 0x07:
-          rate = 60000.0 / 1001.0;
+          rate = 60.0f;


peak3d · 2017-01-11T08:55:50Z

jenkins build this please

xbmc/utils/VC1BitstreamParser.h

+*  <http://www.gnu.org/licenses/>.
+*
+*/
+


peak3d · 2017-01-11T09:17:11Z

jenkins build this please

xbmc/utils/CMakeLists.txt

            BitstreamStats.h
+            BitstreamWriter.cpp


peak3d · 2017-01-11T10:24:38Z

jenkins build this please

Rechi

Since you have moved BS_WL32 and BS_RB16 to other files you must include xbmc/utils/BitstreamReader.h in xbmc/cores/VideoPlayer/DVDCodecs/Video/VTB.cpp and xbmc/utils/BitstreamWriter.h in xbmc/cores/VideoPlayer/DVDCodecs/Video/DVDVideoCodecAndroidMediaCodec.cpp

xbmc/utils/BitstreamWriter.h

+  int       writer_le;
+  uint32_t  bit_buf;
+  int       bit_left;
+  uint8_t   *buf, *buf_ptr, *buf_end;


xbmc/utils/BitstreamWriter.h

+  uint32_t  bit_buf;
+  int       bit_left;
+  uint8_t   *buf, *buf_ptr, *buf_end;
+  int       size_in_bits;


xbmc/utils/BitstreamWriter.cpp

+uint32_t  bit_buf;
+int       bit_left;
+uint8_t   *buf, *buf_ptr, *buf_end;
+int       size_in_bits;


xbmc/utils/BitstreamReader.cpp

+
+  i = (4 - nbytes) * 8 + offbits;
+
+  ret = ((ret << i) >> i) >> ((nbytes * 8) - nbits - offbits);


fritsch · 2017-01-14T10:51:21Z

What I wonder is: if a future android maintainer makes the transition to ffmpeg hwaccel for mediacodec this code would be obsolete? What are the plans here? Is there already an alliance of the willing that make up plans for that future after v17?

MrMC · 2017-01-15T14:30:19Z

ffmpeg/mediacodec needs much more improvement before DVDVideoCodecAndroidMediaCodec can be replaced. Same for VideoToolBox, close but not quite there. Too many missed corner cases.

fritsch · 2017-01-15T15:30:06Z

Can you name one? Am 15.01.2017 3:30 nachm. schrieb "Scott Davilla" <notifications@github.com

…

: ffmpeg/mediacodec needs much more improvement before DVDVideoCodecAndroidMediaCodec can be replaced. Same for VideoToolBox, close but not quite there. Too many missed corner cases. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#11417 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABCfHVBGdf0kKnfbOR-Y090nO-2d0dA4ks5rSi1-gaJpZM4Lf7qt> .

MrMC · 2017-01-15T15:52:21Z

/* TODO: implement surface handling */

MrMC · 2017-01-15T16:04:34Z

For videotoolbox, here are a few

assumes h264 has only one PPS in extra data. There can be more.
does not handle kVTInvalidSessionErr correctly and try to reset the session.
does not use the correct destinationPixelBufferAttributes for pure surface.
does not allow downs scaling at the decoder, needed for 4k/h264 on some devices as they just don't have the memory bandwidth.

peak3d · 2017-01-15T21:15:05Z

jenkins build this please

MrMC · 2017-01-16T13:55:58Z

Nice refactor of bitstream utils.They will be useful to replace the current AC3/EAC3/DTS format probing.

peak3d · 2017-01-16T14:31:11Z

jenkins build this please and don't stop with errors nobody want to see.

peak3d · 2017-01-16T14:51:46Z

jenkins build this please (I know, it was my fault :-)

peak3d · 2017-01-16T15:37:33Z

jenkins build this please

a3kov · 2018-04-01T07:47:55Z

Are these improvements used in Kodi 18 alpha 1 ? I still get audio out of sync problem with most VC-1 files on Minix U9-H (amlogic s912)

peak3d added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Type: Feature non-breaking change which adds functionality v18 Leia Component: Video labels Jan 11, 2017

Rechi reviewed Jan 11, 2017

View reviewed changes

xbmc/utils/BitstreamConverter.cpp

break;

case 0x07:

rate = 60000.0 / 1001.0;

rate = 60.0f;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Rechi reviewed Jan 11, 2017

View reviewed changes

xbmc/utils/VC1BitstreamParser.h

* <http://www.gnu.org/licenses/>.

*

*/

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Rechi reviewed Jan 11, 2017

View reviewed changes

xbmc/utils/CMakeLists.txt

BitstreamStats.h

BitstreamWriter.cpp

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Rechi requested changes Jan 11, 2017

View reviewed changes

thebrid reviewed Jan 13, 2017

View reviewed changes

xbmc/utils/BitstreamReader.cpp

i = (4 - nbytes) * 8 + offbits;

ret = ((ret << i) >> i) >> ((nbytes * 8) - nbits - offbits);

This comment was marked as spam.

Sign in to view

Bitstream refactor / VC1Bitstream parser

e6f1ca2

peak3d merged commit d44d5d5 into xbmc:master Jan 16, 2017

peak3d deleted the bitstream branch January 16, 2017 16:17

stefansaraev mentioned this pull request Jan 18, 2017

DVDVideoCodecAmlogic: remove dead code #11483

Closed

9 tasks

MartijnKaijser modified the milestone: L 18.0-alpha1 Jan 20, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bitstream refactor / VC1Bitstream parser #11417

Bitstream refactor / VC1Bitstream parser #11417

peak3d commented Jan 10, 2017 •

edited

FernetMenta commented Jan 11, 2017

peak3d commented Jan 11, 2017 •

edited

This comment was marked as spam.

This comment was marked as spam.

peak3d commented Jan 11, 2017

This comment was marked as spam.

This comment was marked as spam.

peak3d commented Jan 11, 2017

This comment was marked as spam.

This comment was marked as spam.

peak3d commented Jan 11, 2017

Rechi left a comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

fritsch commented Jan 14, 2017

MrMC commented Jan 15, 2017

fritsch commented Jan 15, 2017 via email

MrMC commented Jan 15, 2017

MrMC commented Jan 15, 2017

peak3d commented Jan 15, 2017

MrMC commented Jan 16, 2017

peak3d commented Jan 16, 2017

peak3d commented Jan 16, 2017

peak3d commented Jan 16, 2017

a3kov commented Apr 1, 2018 •

edited


		i = (4 - nbytes) * 8 + offbits;

		ret = ((ret << i) >> i) >> ((nbytes * 8) - nbits - offbits);

Bitstream refactor / VC1Bitstream parser #11417

Bitstream refactor / VC1Bitstream parser #11417

Conversation

peak3d commented Jan 10, 2017 • edited

Motivation and Context

How Has This Been Tested?

Types of change

FernetMenta commented Jan 11, 2017

peak3d commented Jan 11, 2017 • edited

This comment was marked as spam.

This comment was marked as spam.

peak3d commented Jan 11, 2017

This comment was marked as spam.

This comment was marked as spam.

peak3d commented Jan 11, 2017

This comment was marked as spam.

This comment was marked as spam.

peak3d commented Jan 11, 2017

Rechi left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

fritsch commented Jan 14, 2017

MrMC commented Jan 15, 2017

fritsch commented Jan 15, 2017 via email

MrMC commented Jan 15, 2017

MrMC commented Jan 15, 2017

peak3d commented Jan 15, 2017

MrMC commented Jan 16, 2017

peak3d commented Jan 16, 2017

peak3d commented Jan 16, 2017

peak3d commented Jan 16, 2017

a3kov commented Apr 1, 2018 • edited

peak3d commented Jan 10, 2017 •

edited

peak3d commented Jan 11, 2017 •

edited

a3kov commented Apr 1, 2018 •

edited