Fix crash when closing standalone games #12166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
garbear
added
Type: Cleanup
|
Looks good for me, has also seen also sometimes crashes after the close of a dosbox, thought only that it comes from a bad dosbox dll here at home :) |
|
I think this is the dosbox error you're talking about: libretro/dosbox-libretro#47 |
|
jenkins build this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a game add-on is loaded without a file (standalone mode), when closed it will segfault.
The cause is from #11380, where the in-game saves variable was only initialized for file-based games.
Also included are three code improvements for the games code.