Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Testing] Disc playback improvements #24997

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

[Testing] Disc playback improvements #24997

wants to merge 7 commits into from

Conversation

78andyp
Copy link
Contributor

@78andyp 78andyp commented Apr 14, 2024

Description

Combination of #24304 and #24720 and patch(es) to get them working together.

Motivation and context

How has this been tested?

What is the effect on users?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@78andyp 78andyp marked this pull request as draft April 14, 2024 21:10
@jenkins4kodi jenkins4kodi added the Rebase needed PR that does not apply/merge cleanly to current base branch label Apr 20, 2024
@78andyp
Improve episode display/selection for multi-episode discs.
895d8af 
	modified:   addons/resource.language.en_gb/resources/strings.po
	modified:   system/settings/settings.xml
	modified:   xbmc/FileItem.cpp
	modified:   xbmc/FileItem.h
	modified:   xbmc/application/Application.cpp
	modified:   xbmc/cores/VideoPlayer/DVDInputStreams/DVDFactoryInputStream.cpp
	modified:   xbmc/cores/VideoPlayer/DVDInputStreams/DVDInputStreamBluray.cpp
	modified:   xbmc/cores/VideoPlayer/DVDInputStreams/DVDInputStreamNavigator.cpp
	modified:   xbmc/cores/VideoPlayer/DVDInputStreams/DVDInputStreamNavigator.h
	modified:   xbmc/dialogs/GUIDialogSimpleMenu.cpp
	modified:   xbmc/dialogs/GUIDialogSimpleMenu.h
	modified:   xbmc/filesystem/BlurayDirectory.cpp
	modified:   xbmc/filesystem/BlurayDirectory.h
	modified:   xbmc/filesystem/CMakeLists.txt
	modified:   xbmc/filesystem/DVDDirectory.cpp
	modified:   xbmc/filesystem/DVDDirectory.h
	new file:   xbmc/filesystem/DVDFile.cpp
	new file:   xbmc/filesystem/DVDFile.h
	modified:   xbmc/filesystem/Directory.cpp
	modified:   xbmc/filesystem/Directory.h
	modified:   xbmc/filesystem/FileFactory.cpp
	modified:   xbmc/filesystem/IDirectory.h
	modified:   xbmc/settings/DiscSettings.h
	modified:   xbmc/settings/Settings.h
	modified:   xbmc/utils/SaveFileStateJob.cpp
	modified:   xbmc/utils/URIUtils.cpp
	modified:   xbmc/video/VideoDatabase.cpp
	modified:   xbmc/video/VideoDatabase.h
	modified:   xbmc/video/guilib/VideoGUIUtils.cpp
	modified:   xbmc/video/windows/GUIWindowVideoBase.cpp
@78andyp
Improve user experience when playing movies/episodes from Bluray ISO/…
dbd5af9 
…BDMV.

	modified:   addons/resource.language.en_gb/resources/strings.po
	modified:   xbmc/FileItem.cpp
	modified:   xbmc/FileItem.h
	modified:   xbmc/PlayListPlayer.cpp
	modified:   xbmc/PlayListPlayer.h
	modified:   xbmc/application/Application.cpp
	modified:   xbmc/application/Application.h
	modified:   xbmc/dialogs/GUIDialogContextMenu.h
	modified:   xbmc/dialogs/GUIDialogSimpleMenu.cpp
	modified:   xbmc/dialogs/GUIDialogSimpleMenu.h
	modified:   xbmc/utils/SaveFileStateJob.cpp
	modified:   xbmc/video/VideoDatabase.cpp
	modified:   xbmc/video/VideoDatabase.h
	modified:   xbmc/video/windows/GUIWindowVideoBase.cpp
	modified:   xbmc/video/windows/GUIWindowVideoBase.h
	modified:   xbmc/windows/GUIMediaWindow.cpp

	modified:   addons/resource.language.en_gb/resources/strings.po
	modified:   xbmc/FileItem.cpp
	modified:   xbmc/FileItem.h
	modified:   xbmc/PlayListPlayer.cpp
	modified:   xbmc/PlayListPlayer.h
	modified:   xbmc/application/Application.cpp
	modified:   xbmc/application/Application.h
	modified:   xbmc/dialogs/GUIDialogContextMenu.h
	modified:   xbmc/dialogs/GUIDialogSimpleMenu.cpp
	modified:   xbmc/dialogs/GUIDialogSimpleMenu.h
	modified:   xbmc/utils/SaveFileStateJob.cpp
	modified:   xbmc/video/VideoDatabase.cpp
	modified:   xbmc/video/VideoDatabase.h
	modified:   xbmc/video/windows/GUIWindowVideoBase.cpp
	modified:   xbmc/video/windows/GUIWindowVideoBase.h
	modified:   xbmc/windows/GUIMediaWindow.cpp
@78andyp
Patch to get both PRs working together
f013a1c 
	modified:   xbmc/FileItem.cpp
	modified:   xbmc/FileItem.h
	modified:   xbmc/application/Application.cpp
	modified:   xbmc/cores/VideoPlayer/DVDInputStreams/DVDFactoryInputStream.cpp
	modified:   xbmc/cores/VideoPlayer/DVDInputStreams/DVDInputStreamNavigator.cpp
	modified:   xbmc/dialogs/GUIDialogSimpleMenu.cpp
	modified:   xbmc/filesystem/DVDDirectory.cpp
	modified:   xbmc/filesystem/DVDDirectory.h
	modified:   xbmc/filesystem/File.cpp
	modified:   xbmc/utils/SaveFileStateJob.cpp
	modified:   xbmc/utils/URIUtils.cpp
	modified:   xbmc/utils/URIUtils.h
	modified:   xbmc/video/VideoDatabase.cpp
	modified:   xbmc/video/VideoDatabase.h
	modified:   xbmc/video/VideoInfoTag.cpp
	modified:   xbmc/video/VideoInfoTag.h
	modified:   xbmc/video/windows/GUIWindowVideoBase.cpp
@78andyp
Fixes
68d51a3
@78andyp
Jenkins and build fixes
4193ab0 
	modified:   xbmc/cores/VideoPlayer/DVDInputStreams/DVDInputStreamBluray.cpp
	modified:   xbmc/cores/VideoPlayer/DVDInputStreams/DVDInputStreamNavigator.cpp
	modified:   xbmc/dialogs/GUIDialogSimpleMenu.cpp
	modified:   xbmc/filesystem/BlurayDirectory.cpp
	modified:   xbmc/filesystem/IDirectory.h
	modified:   xbmc/utils/SaveFileStateJob.cpp
	modified:   xbmc/video/VideoDatabase.cpp
	modified:   xbmc/video/VideoDatabase.h
	modified:   xbmc/windows/GUIMediaWindow.cpp
@jenkins4kodi jenkins4kodi removed the Rebase needed PR that does not apply/merge cleanly to current base branch label Apr 23, 2024
@jenkins4kodi
Copy link
Contributor

I've made some formatting changes to meet the current code style. The diffs are available in the following links:

For more information please see our current code style guidelines.

@78andyp 78andyp mentioned this pull request Apr 26, 2024
Merged
14 tasks
@jenkins4kodi jenkins4kodi added the Rebase needed PR that does not apply/merge cleanly to current base branch label Apr 26, 2024
@jenkins4kodi
Copy link
Contributor

@78andyp this needs a rebase

@78andyp 78andyp mentioned this pull request May 1, 2024
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Rebase needed PR that does not apply/merge cleanly to current base branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@78andyp @jenkins4kodi