Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cmake] Move effects11 library to external library usage #25144

Merged
merged 2 commits into from May 8, 2024

Conversation

fuzzard
Copy link
Contributor

@fuzzard fuzzard commented May 6, 2024

Description

Remove code that is not team kodi code, and use as any other lib

Motivation and context

Remove code that isnt ours from tree. Source lib from upstream and treat as any other external lib

How has this been tested?

Build win x64

What is the effect on users?

N/A

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@fuzzard fuzzard added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Platform: Windows CMake Platform: WindowsStore labels May 6, 2024
@fuzzard fuzzard added this to the "P" 22.0 Alpha 1 milestone May 6, 2024
@fuzzard fuzzard added the v22 "P" label May 6, 2024
@jenkins4kodi jenkins4kodi added the Rebase needed PR that does not apply/merge cleanly to current base branch label May 6, 2024
@jenkins4kodi jenkins4kodi removed the Rebase needed PR that does not apply/merge cleanly to current base branch label May 6, 2024
fuzzard added 2 commits May 7, 2024 10:00
A module to enable locating and building the effects11 lib
Copy link
Member

@garbear garbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward and removes 20K SLOC. What's not to love?

@fuzzard
Copy link
Contributor Author

fuzzard commented May 8, 2024

Linux failure unrelated (05:39:48 [ FAILED ] TestHTTPDirectory.IsStarted)

@fuzzard fuzzard merged commit 06dd31e into xbmc:master May 8, 2024
1 check failed
@fuzzard fuzzard deleted the cmake_effects11 branch May 8, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake Platform: Windows Platform: WindowsStore Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v22 "P"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants