Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI] Move dialog settings button and control ID range #25147

Merged
merged 1 commit into from May 9, 2024

Conversation

Hitcher
Copy link
Contributor

@Hitcher Hitcher commented May 6, 2024

Description

Moves the range of negative IDs used for dialog settings to avoid overlapping with positive IDs used for buttons.
Button start changed from -100 to -200.
Control start changed from -80 to -180.

Motivation and context

Fixes #25125

How has this been tested?

Tested on Windows using https://mirrors.kodi.tv/test-builds/windows/win64/KodiSetup-20240506-a1c6d8ec-dialog_settings_id_range-x64.exe

What is the effect on users?

Screenshots (if appropriate):

Previous problem:
image
The number of settings in this addon exceed 80 so they use positive numbers which then clash with the button IDs.

After fix:
screenshot00011
screenshot00012
screenshot00013
screenshot00014
screenshot00015
No ID clashes.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

Moves the range of negative IDs used for dialog settings to avoid overlapping with positive IDs used for buttons in dialogs.
Button start changed from -100 to -200.
Control start changed from -80 to -180.
Fixes #25125
@Hitcher Hitcher added Type: Fix non-breaking change which fixes an issue Component: GUI engine v22 "P" labels May 6, 2024
@Hitcher Hitcher added this to the "P" 22.0 Alpha 1 milestone May 6, 2024
@Hitcher Hitcher requested review from CrystalP and garbear May 6, 2024 12:47
Copy link
Contributor

@CrystalP CrystalP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no runtime testing, the code should be OK with that change.

@Hitcher Hitcher merged commit f5a5789 into xbmc:master May 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collision of build-in controls, e.g. in DialogAddonSettings.xml
2 participants