[Omega] Fix loading ISO files on Android arm-v7a

[joseluismarti]

Description

There is an issue on 32-bit Android devices when trying to open an ISO file from the internal storage, kodi force closes and displays the following debug message:

D Kodi : **ERROR: fseeko (): Invalid argument

The libcdio library is calling the fseeko function with a 64-bit off_t argument and this function is not available in Android API 21, was added in 24.

The fix would be to target 24 as done in v22.

I propose a workaround to continue at level 21 in v21: disable iso9660pp so that libudfread is used to open ISO files, similar to how network ISO files are opened.

How has this been tested?

Tested to open and play a DVD ISO file on a 32-bit Android device.

Types of change

• Bug fix (non-breaking change which fixes an issue)
• Clean up (non-breaking change which removes non-working, unmaintained functionality)
• Improvement (non-breaking change which improves existing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that will cause existing functionality to change)
• Cosmetic change (non-breaking change that doesn't touch code)
• Student submission (PR was done for educational purposes and will be treated as such)
• None of the above (please explain below)

Checklist:

• My code follows the Code Guidelines of this project
• My change requires a change to the documentation, either Doxygen or wiki
• I have updated the documentation accordingly
• I have read the Contributing document
• I have added tests to cover my change
• All new and existing tests passed

[joseluismarti]

The builder has ignored the argument:

-- ISO9660PP enabled: Yes

Locally it has worked, any advice?

[thexai]

No idea, ping @fuzzard

[thexai]

Maybe False instead OFF ?

[joseluismarti]

Maybe False instead OFF ?

Format is correct (also seen here) as it works locally. Maybe when configuring it's redefined, better wait for ping

[joseluismarti]

Works! thank you both

[fuzzard]

My concern is what is disabling the iso9660p library actually going to do?

I dont understand how this is a new problem in Omega over Nexus. Nothing has changed regarding libcdio in Omega as far as i could see. is there something specifically changed in Omega that somehow caused this? Does this even work in Nexus?

[joseluismarti]

I've checked that the last release that opens an iso file is 18.9, at that time libudfread was used.

From 19.0 onwards crashes with the invalid argument message in fseeko.

libcdio was added in 19.0 (#16262)

[thexai]

Tested on Sony TV (arm-v7a): tested DVD ISO from USB storage and SMB.

Also tested Blu-Ray BDMV folder and BD ISO from SMB for possible regressions. All is working fine.

[howie-f]

Tested on Sony TV (arm-v7a): tested DVD ISO from USB storage and SMB.

apart from fuzzard's concerns.. wasn't the error only happening when trying to open an ISO from internal storage? not SMB/USB

[thexai]

USB also was crashing for me in this Sony TV with Play Store version

[lrusak]

What about making the UDF implementation higher priority?

xbmc/xbmc/filesystem/FileDirectoryFactory.cpp

Line 158 in 161ccd0

return new CUDFDirectory();

[joseluismarti]

What about making the UDF implementation higher priority?

Could also be fixed in this way, but it would affect all platforms. To reduce the risks better the current solution that only affects Android arm-v7a.

[lrusak]

What about making the UDF implementation higher priority?

Could also be fixed in this way, but it would affect all platforms. To reduce the risks better the current solution that only affects Android arm-v7a.

I would check if that solves the problem.

Also has this change been made to master? I see it's PR'd to the Omega branch.

[joseluismarti]

Also has this change been made to master? I see it's PR'd to the Omega branch.

Master targets Android API 24, at this level fseeko is "fully" available and therefore libcdio works properly, no change is necessary.

[lrusak]

Also has this change been made to master? I see it's PR'd to the Omega branch.

Master targets Android API 24, at this level fseeko is "fully" available and therefore libcdio works properly, no change is necessary.

Could libcdio be patched to fix the issue?

[joseluismarti]

Could libcdio be patched to fix the issue?

A 64-bit fseeko function or something similar should be implemented, but at the moment since it doesn't affect Master and there is a workaround that works for v21 I don't think it's worth.

[fritsch]

@lrusak reasoning @joseluismarti fine with you? Given that it is about v21 stable?

[lrusak]

@lrusak reasoning @joseluismarti fine with you? Given that it is about v21 stable?

I don't really care, I was just suggesting alternatives. There was some discussion in #android-external on slack about alternatives. I'm not sure where that got to though and ultimately it may be up to @fuzzard

[fritsch]

Yeah - also not my usecase. So whatever was the winner of the discussion should make it.

[howie-f]

So whatever was the winner of the discussion should make it.

there was no real winner. i just raised the concern that disabling iso9660pp could probably break playback of physical dvd‘s… but android is also not my use case nor can i test dvd playback anymore.

not an easy decision. maybe merge as is and revert if shit happens 🤷

[joseluismarti]

I also don't use this feature just to search for the fix, in the tests I've done I can see the content of the iso file and the playback also works.

The reporter and someone else confirm that it works, apparently well.

[fritsch]

Good - if we all don't know. Let's do what @howie-f suggested.

[fritsch]

Thanks everyone involved.