[cleanup] Use FFmpeg for AV_RBxx, AV_WBxx and AV_WLxx functions and drop 'BitstreamWriter.cpp' #25183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
utils/BitstreamWriter.cpp
Motivation and context
With #25172 I realized that we are using a replica of FFmpeg
AV_RB24
,AV_RB32
, etc.. functions when the FFmpeg header is available currently<libavutil/intreadwrite.h>
and in fact is already used in some places:xbmc/xbmc/cores/AudioEngine/Utils/PackerMAT.cpp
Line 80 in adad147
Then is a direct replacement to remove duplicated code.
Once replaced also
utils/BitstreamWriter.cpp
is a dead code becauseCBitstreamWriter::WriteBits()
it's not used in any place.How has this been tested?
Runtime tested in Shield with Dolby Vision profile 7 file that make use of BitstreamConverter when enabled DV compatibility mode (profile 7 ---> 8 conversion).
What is the effect on users?
nothing
Screenshots (if appropriate):
Types of change
Checklist: