Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAYLIST::Id: convert to enum class #25187

Merged
merged 1 commit into from May 11, 2024

Conversation

notspiff
Copy link
Contributor

Description

Converter int type and loose values to proper enum class

Motivation and context

While there is a lot of casting to int, at least everything is explicitly cast and confirmed by
the compiler now.

How has this been tested?

It builds.

What is the effect on users?

None

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@notspiff notspiff added Type: Improvement non-breaking change which improves existing functionality v22 "P" labels May 10, 2024
@notspiff notspiff added this to the "P" 22.0 Alpha 1 milestone May 10, 2024
Copy link
Member

@garbear garbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the change.

So strong... the bikeshedding beckons... I like capital ID 🙂 What does our style guide say?

@notspiff
Copy link
Contributor Author

it says, you want that tint on your shed, you do it.

@garbear
Copy link
Member

garbear commented May 10, 2024

Toss some paint on it and call it a day. Id is good.

@notspiff notspiff merged commit 436befa into xbmc:master May 11, 2024
2 checks passed
@notspiff notspiff deleted the playlist_id_enum_class branch May 11, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement non-breaking change which improves existing functionality v22 "P"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants