New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mips arch #455
Add mips arch #455
Conversation
Most taken from the linux kernel.
Hey. New MIPS atmomics. How about fixing the Linux AtomicAdd and AtomicSubtract return values. @theuni: Do you want to get the tests running for these? |
Heh, fixing x86 is out of my league I'm afraid. As for the tests.. sure. Is anything needed to hook them up? |
Yeah ... that was a nudge to phi :) |
@@ -21,7 +21,7 @@ | |||
* along with this program; if not, write to the Free Software | |||
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA. | |||
*****************************************************************************/ | |||
#if !defined(_WIN32) && !defined(__ppc__) && !defined(__powerpc__) && !defined(__arm__) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
As for the tests, I have them separated out from boost now. I need to do a little work on them yet, but I'll let you know this weekend when you can give them a shot. Of course you'll need to run them on a mips machine. |
I'me beginning to thing that we should be using compiler atomic where supported. As far as I know, the only compiler that does not have the nice atomic intrinsics is osx's gcc-4.0. Pretty much everything else is at least 4.2 and above. As for osx, after 11.0 release, we bump to 10.6sdk and move to gcc-4.2/llvm-cpp-4.2. |
Ok, the python stuff can be removed as they can be influenced with env vars. That leaves the implementation clean. I'll be pushing this in soon unless there are any other complaints. |
Closing this, it'll come as part of a bigger refactor. |
Nothing exciting here, basically just the same guards we already have for ppc/arm, plus some atomics borrowed from the Linux kernel (and split out to avoid making things messy).