Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mips arch #455

Closed
wants to merge 3 commits into from
Closed

Add mips arch #455

wants to merge 3 commits into from

Conversation

theuni
Copy link
Contributor

@theuni theuni commented Sep 30, 2011

Nothing exciting here, basically just the same guards we already have for ppc/arm, plus some atomics borrowed from the Linux kernel (and split out to avoid making things messy).

@jimfcarroll
Copy link
Member

Hey. New MIPS atmomics. How about fixing the Linux AtomicAdd and AtomicSubtract return values.

@theuni: Do you want to get the tests running for these?

@theuni
Copy link
Contributor Author

theuni commented Sep 30, 2011

Heh, fixing x86 is out of my league I'm afraid.

As for the tests.. sure. Is anything needed to hook them up?

@jimfcarroll
Copy link
Member

Yeah ... that was a nudge to phi :)

@@ -21,7 +21,7 @@
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
*****************************************************************************/
#if !defined(_WIN32) && !defined(__ppc__) && !defined(__powerpc__) && !defined(__arm__)

This comment was marked as spam.

@jimfcarroll
Copy link
Member

As for the tests, I have them separated out from boost now. I need to do a little work on them yet, but I'll let you know this weekend when you can give them a shot. Of course you'll need to run them on a mips machine.

@davilla
Copy link
Contributor

davilla commented Sep 30, 2011

I'me beginning to thing that we should be using compiler atomic where supported. As far as I know, the only compiler that does not have the nice atomic intrinsics is osx's gcc-4.0. Pretty much everything else is at least 4.2 and above. As for osx, after 11.0 release, we bump to 10.6sdk and move to gcc-4.2/llvm-cpp-4.2.

@theuni
Copy link
Contributor Author

theuni commented Oct 12, 2011

Ok, the python stuff can be removed as they can be influenced with env vars. That leaves the implementation clean.

I'll be pushing this in soon unless there are any other complaints.

@theuni
Copy link
Contributor Author

theuni commented Apr 4, 2012

Closing this, it'll come as part of a bigger refactor.

@theuni theuni closed this Apr 4, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants