New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for file based stubs and improve support for disc stubs #7006
Conversation
0c8185c
to
6aa674f
Compare
Is this have a chance to get in kodi core? |
return strValue; | ||
} | ||
|
||
bool CEFileFile::GetXMLString(const CURL& url, std::string strXMLTag, std::string& strValue) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Is "efile" a commonly used name for this sort of thing or something you invented?:) What does the e stand for? |
711bae1
to
61cf3e7
Compare
@tamland thanks for the review. |
Twice then? Once for reading the message when displaying the dialog, once when resolving the path. Remember, it can live on network. I'm not very familiar with these parts, so others will have to comment. Maybe look at how .strm files are handled wrt reading? |
CONTROL_ENABLE_ON_CONDITION(ID_BUTTON_PLAY, g_mediaManager.IsDiscInDrive()); | ||
if (isDisc) | ||
stubOriginal = URIUtils::GetOpticalMediaPath(); | ||
CONTROL_ENABLE_ON_CONDITION(ID_BUTTON_PLAY, CFile::Exists(stubOriginal)); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
I checked strm files like @tamland suggested but they are simply playlists. They work similarly to how disc stubs work right now changing the path before to start to play so no resume support, no info, no automatic watched state etc etc. |
@phate89 any plans to resurrect this PR? |
@phate89 this needs a rebase |
I will close this PR. If there's interest please open a new one (with required changes if needed). |
This is a different version of #551.
It's the first time I go deep in Kodi code so please be patient with me.
I tried to hide stub files under Kodi vfs in efile:// urls. I used something similar to a mix of Zip and special protocol file for efile stubs.
I also improved disc stubs handling. Now theyworks similarly to iso files. Both they should work better now (thumbs creation, resume support, watched state, right info, episode bookmarks etc etc).
I also removed several CFileItem creations only to get to IsDiscImage with a specific URIUtils method (called also from CFileItem).
I have 3 doubts:
Needs xcode sync