cleanup ui sound system #7684
Merged
cleanup ui sound system #7684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamland
added
API change
Type: Cleanup
|
@Montellese Can you review please? |
tamland
force-pushed
the
ui_sounds_cleanup
branch
from
1195eeb
to
985c245
Compare
|
jenkins build this please |
| @@ -53,6 +53,10 @@ void CGUIAudioManager::OnSettingChanged(const CSetting *setting) | |||
| const std::string &settingId = setting->GetId(); | |||
| if (settingId == CSettings::SETTING_LOOKANDFEEL_SOUNDSKIN) | |||
| { | |||
| //Migrate "OFF" setting | |||
| if (((CSettingString*)setting)->GetValue() == "OFF") | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Looks ok apart from the minors. |
tamland
force-pushed
the
ui_sounds_cleanup
branch
from
985c245
to
e44afd6
Compare
|
done, thanks |
| @@ -53,6 +53,7 @@ void CGUIAudioManager::OnSettingChanged(const CSetting *setting) | |||
| const std::string &settingId = setting->GetId(); | |||
| if (settingId == CSettings::SETTING_LOOKANDFEEL_SOUNDSKIN) | |||
| { | |||
|
|
|||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
One last minor left. |
remove loading from load sounds from skin dir, system/sounds, user/sounds and support directory based themes to unify it with skins, langauges etc.
tamland
force-pushed
the
ui_sounds_cleanup
branch
from
e44afd6
to
9f5d962
Compare
|
jenkins build this please |
|
@Montellese, this one should be good to go now, right? |
|
Yes my comments have been addressed. |
|
jenkins build this please |
MartijnKaijser
added a commit
that referenced
this pull request
Aug 12, 2015
cleanup ui sound system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up old stuff after the move to addons. It is now purely addon based. The purpose of this is simplify the code, and UI-wise make it behave the same as skins and other with a "Get more" button and the same setting select dialog.
To be clear, this removes the ability to load themes from the 'sounds' directory (in system and home), and for skins to include sounds (they should be provided as a separate addon).